Page MenuHomeFreeBSD

misc/xiphos: Update to 4.2.1
ClosedPublic

Authored by salvadore on Jun 17 2020, 1:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 21 2024, 12:08 PM
Unknown Object (File)
Feb 10 2024, 12:38 PM
Unknown Object (File)
Jan 11 2024, 1:01 PM
Unknown Object (File)
Dec 27 2023, 10:27 AM
Unknown Object (File)
Dec 27 2023, 10:26 AM
Unknown Object (File)
Dec 27 2023, 10:02 AM
Unknown Object (File)
Dec 20 2023, 9:28 PM
Unknown Object (File)
Dec 20 2023, 4:12 AM
Subscribers

Details

Summary

While here, also switch WWW to https.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tcberner added inline comments.
head/misc/xiphos/Makefile
44

I don't quite understand the issue. Why are you not using the proper release tar ball which includes said file?

https://github.com/crosswire/xiphos/releases/tag/4.2.1

e.g. xiphos-4.2.1.tar.xz

This revision now requires changes to proceed.Jun 17 2020, 1:25 PM
head/misc/xiphos/Makefile
44

I could not find a way to get such file using USE_GITHUB. If it is possible to do it of course I would be glad to do it.

Otherwise I think the choice is between:

  • creating the missing the file manually;
  • drop USE_GITHUB and manually specify MASTER_SITES and DISTFILES.

I choosed the first solution as it looked cleaner to me.

Use the release file instead of patching the sources downloaded with USE_GITHUB, as suggested by tcberner.

I believe this is ready to land?

This revision was not accepted when it landed; it landed in state Needs Review.Jun 19 2020, 5:37 PM
This revision was automatically updated to reflect the committed changes.