Move "gnop -s" example from md(8) to gnop(8).
AbandonedPublic
Actions

Authored by trasz on Jul 25 2015, 3:10 PM.

Details

Reviewers

None

Group Reviewers

manpages

Summary

Move "gnop -s" example from md(8) to gnop(8); it fits better there.
Also tweak the description a little.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

trasz updated this revision to Diff 7296.Jul 25 2015, 3:10 PM

trasz retitled this revision from to Move "gnop -s" example from md(8) to gnop(8)..

trasz updated this object.

trasz edited the test plan for this revision. (Show Details)

Herald added a reviewer: manpages. · View Herald TranscriptJul 25 2015, 3:10 PM

Herald added a subscriber: imp. · View Herald Transcript

The question addressed by that example was "how do I mount this disk image that has a bunch of header information that should be skipped over?"

And gnop(8) did not even mention that capability.

I'd suggest leaving the example in mdconfig.8 and expanding gnop.8 to describe more of its capabilities.

wblock@ is right; the point of this example is to point people to gnop, which they might not know about, so putting it inside gnop(8) would defeat its purpose.

Revision Contents
Changeset List

Path

Size

sbin/

geom/

class/

nop/

gnop.8

12 lines

mdconfig/

mdconfig.8

11 lines

Diff 7296

View Options

sbin/geom/class/nop/gnop.8

	Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
	#include <sys/cpuset.h>			#include <sys/cpuset.h>
	#include <sys/lock.h>			#include <sys/lock.h>
	#include <sys/mutex.h>			#include <sys/mutex.h>

	#include <vm/vm.h>			#include <vm/vm.h>
	#include <vm/pmap.h>			#include <vm/pmap.h>

	#include <machine/bus.h>			#include <machine/bus.h>
				#include <machine/cpu.h>
	#include <machine/intr.h>			#include <machine/intr.h>

	#include "pic_if.h"			#include "pic_if.h"

	#include "gic_v3_reg.h"			#include "gic_v3_reg.h"
	#include "gic_v3_var.h"			#include "gic_v3_var.h"

	/* Device and PIC methods */			/* Device and PIC methods */
	▲ Show 20 Lines • Show All 166 Lines • ▼ Show 20 Lines
	* PIC interface.			* PIC interface.
	*/			*/
	static void			static void
	gic_v3_dispatch(device_t dev, struct trapframe *frame)			gic_v3_dispatch(device_t dev, struct trapframe *frame)
	{			{
	uint64_t active_irq;			uint64_t active_irq;

	while (1) {			while (1) {
				if (CPU_MATCH_ERRATA_CAVIUM_THUNDER_1_1) {
				/*
				* Hardware: Cavium ThunderX
				* Chip revision: Pass 1.0, Pass 1.1
				* ERRATUM: 22978, 23154
				impUnsubmitted Not Done Inline Actions So both Pass 1.0 and 1.1 have this errata. Is Cavium really going to market with Pass 1.1? that likely means we'd have to keep this around for a long time. If that's just the first wave and there will be a Pass 2.0 which fixes this, that would be better. imp: So both Pass 1.0 and 1.1 have this errata. Is Cavium really going to market with Pass 1.1? that…
				emasteUnsubmitted Not Done Inline Actions As far as we know right now, yes. emaste: As far as we know right now, yes.
				*/
				__asm __volatile("nop;nop;nop;nop;nop;nop;nop;nop;\n"
				"mrs %0, ICC_IAR1_EL1\n"
				"nop;nop;nop;nop;dsb sy;" : "=&r" (active_irq));
				} else {
	active_irq = gic_icc_read(IAR1);			active_irq = gic_icc_read(IAR1);
				andrewUnsubmitted Not Done Inline Actions Quoting https://lkml.org/lkml/2015/7/6/247 If you need an instruction sequence to be consecutive, then it _must_ be one single asm(). I would also like a comment explaining why all the nops are needed, and on what hardware the errata applies to. There have been a few places with other architectures where they needed a collection of nops, but nobody can remember why, or knew if they are still needed. andrew: Quoting https://lkml.org/lkml/2015/7/6/247 If you need an instruction sequence to be…
				wma_semihalf.comAuthorUnsubmitted Not Done Inline Actions Fixed, comments added. Unfortunately, these are the only information than can go public. wma_semihalf.com: Fixed, comments added. Unfortunately, these are the only information than can go public.
				emasteUnsubmitted Not Done Inline Actions Is it possible to expand on the meaning of `Pass 1.0/1.1`? emaste: Is it possible to expand on the meaning of `Pass 1.0/1.1`?
				}

	if (__predict_false(active_irq == ICC_IAR1_EL1_SPUR))			if (__predict_false(active_irq == ICC_IAR1_EL1_SPUR))
	break;			break;

	if (__predict_true((active_irq >= GIC_FIRST_PPI &&			if (__predict_true((active_irq >= GIC_FIRST_PPI &&
	active_irq <= GIC_LAST_SPI) \|\| active_irq >= GIC_FIRST_LPI)) {			active_irq <= GIC_LAST_SPI) \|\| active_irq >= GIC_FIRST_LPI)) {
	arm_dispatch_intr(active_irq, frame);			arm_dispatch_intr(active_irq, frame);
	continue;			continue;
	▲ Show 20 Lines • Show All 342 Lines • Show Last 20 Lines