Page MenuHomeFreeBSD
Differential D25208

net-mgmt/nsca-ng: Update to 1.6, now compiles on -12 and -13
ClosedPublic
Actions

Authored by knan-rfo_modirum.com on Jun 10 2020, 1:37 PM.
Tags
None
Referenced Files
F102362714: D25208.diff
Mon, Nov 11, 5:59 AM
Unknown Object (File)
Wed, Oct 30, 4:27 AM
Unknown Object (File)
Fri, Oct 18, 1:16 PM
Unknown Object (File)
Oct 3 2024, 6:11 PM
Unknown Object (File)
Oct 1 2024, 3:22 PM
Unknown Object (File)
Sep 29 2024, 9:45 PM
Unknown Object (File)
Sep 28 2024, 1:31 AM
Unknown Object (File)
Sep 26 2024, 11:41 PM
View All 66 Files
Subscribers
fernape
mat

Details

Reviewers
pi
swills
Commits
rP541229: MFH: r541222
rP541222: net-mgmt/nsca-ng: Update to 1.6
Summary

nsca-ng development has moved to github. Refresh to version 1.6 from there.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

knan-rfo_modirum.com created this revision.Jun 10 2020, 1:37 PM
Herald added a subscriber: mat. · View Herald TranscriptJun 10 2020, 1:37 PM
knan-rfo_modirum.com requested review of this revision.Jun 10 2020, 1:37 PM
fernape added a subscriber: fernape.Jun 11 2020, 6:41 AM

Thanks for the patch.
You might be interested in using ports-mgmt/portlint and ports-mgmt/poudriere. These tools catch most if not all of the common pitfalls we face when updating ports.
You can have more information here:
https://www.freebsd.org/doc/en/books/porters-handbook/book.html#testing-poudriere
https://www.freebsd.org/doc/en/books/porters-handbook/book.html#porting-portlint

net-mgmt/nsca-ng/Makefile
2

The review patch doesn't apply cleanly for Makefile. The version in the repository already contains this line for example.

6

Delete since we are bumping PORTVERSION

8

Move up right after PORTVERSION

12

This should be after USES=
Also GH_PROJECT can be deleted since it defaults to PORTNAME

knan-rfo_modirum.com updated this revision to Diff 72977.Jun 11 2020, 11:08 AM

Addressed review comments, now passes portlint, already passed poudriere testport.

knan-rfo_modirum.com marked 4 inline comments as done.Jun 11 2020, 11:10 AM

Thanks for the review. Updated patch addresses these nits.

fernape added inline comments.Jun 11 2020, 1:55 PM
net-mgmt/nsca-ng/Makefile
46

WARN: Makefile: [43]: IGNORE messages should begin with a lowercase letter and end without a period.

knan-rfo_modirum.com added a comment.Jun 12 2020, 9:08 AM

Pre-existing warning before this patch, so a bit out of scope I feel. But I can of course fix it.

knan-rfo_modirum.com updated this revision to Diff 73017.Jun 12 2020, 10:54 AM

Fix remaining pre-existing portlint nits.

knan-rfo_modirum.com marked an inline comment as done.Jun 12 2020, 10:55 AM
fernape added a comment.Jun 13 2020, 10:04 AM

Thanks for that!

Builds OK for {11.3,12.1}{amd64,i386} and 13-current

LGTM

pi accepted this revision.Jul 4 2020, 12:01 PM

Testbuilds are fine. fernape, are you going to commit this ?

This revision is now accepted and ready to land.Jul 4 2020, 12:01 PM
fernape added a comment.Jul 4 2020, 3:53 PM
In D25208#565139, @pi wrote:

Testbuilds are fine. fernape, are you going to commit this ?

Sure thing. Thanks for reviewing this.

Closed by commit rP541222: net-mgmt/nsca-ng: Update to 1.6 (authored by fernape). · Explain WhyJul 4 2020, 4:03 PM
This revision was automatically updated to reflect the committed changes.
fernape added a commit: rP541222: net-mgmt/nsca-ng: Update to 1.6.
fernape added a commit: rP541229: MFH: r541222.Jul 4 2020, 6:01 PM

Revision Contents
Changeset List

PathSize
net-mgmt/
nsca-ng/
17 lines
5 lines
files/

Diff 72923

View Options

net-mgmt/nsca-ng/Makefile

Loading...
View Options

net-mgmt/nsca-ng/distinfo

Loading...
View Options

net-mgmt/nsca-ng/files/patch-src_common_tls.c

Loading...