Page MenuHomeFreeBSD
Differential D25205

lockf(1): Add EXAMPLES section
ClosedPublic
Actions

Authored by fernape on Jun 10 2020, 6:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 3, 2:57 PM
Unknown Object (File)
Mon, May 27, 1:42 AM
Unknown Object (File)
May 10 2024, 2:23 PM
Unknown Object (File)
May 8 2024, 5:14 AM
Unknown Object (File)
May 6 2024, 8:02 AM
Unknown Object (File)
May 2 2024, 12:11 AM
Unknown Object (File)
May 1 2024, 11:45 PM
Unknown Object (File)
May 1 2024, 11:44 PM
View All 21 Files
Subscribers
bcr
imp
Contributor Reviews (src)

Details

Reviewers
bcr
Group Reviewers
manpages
Commits
rS362299: lockf(1): Add EXAMPLES section
Summary
  • Add pretty small EXAMPLES section
  • While here, fix a warning in line 98 (new sentence in new line)
Test Plan
  • mandoc -Tlint clean
  • aspell happy
  • man ./lockf.1 renders the page properly

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 31606
Build 29194: arc lint + arc unit

Event Timeline

fernape created this revision.Jun 10 2020, 6:26 AM
Herald added a reviewer: manpages. · View Herald TranscriptJun 10 2020, 6:26 AM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
fernape requested review of this revision.Jun 10 2020, 6:26 AM
Harbormaster completed remote builds in B31604: Diff 72914.Jun 10 2020, 6:26 AM
bcr added a subscriber: bcr.Jun 10 2020, 7:50 AM

I'd use "will" instead of "shall".

lockf/lockf.1
174

s/sleesp/sleeps/

178

How about "Success" instead of "Hello" ?

fernape updated this revision to Diff 72918.Jun 10 2020, 8:12 AM

Address issues spotted by bcr@

  • s/Hello/Success
  • s/sleesp/sleeps
  • s/shall/will
Harbormaster completed remote builds in B31606: Diff 72918.Jun 10 2020, 8:12 AM
fernape marked 2 inline comments as done.Jun 10 2020, 8:14 AM
fernape added inline comments.
lockf/lockf.1
174

This one hurts.

I tend to do this before submitting: svn diff | aspell --lang=en list and then review the list. Clearly I didn't spot this one, but is there a better way of spell checking the changes?

bcr accepted this revision.Jun 10 2020, 8:19 AM

Good to go now, thank you!

lockf/lockf.1
174

Maybe ispell? But I have my own internal spell checking, which is also not perfect and misses typos occasionally. Don't worry, that's why we have reviews where more eyeballs help catch these sort of things. ;-)

This revision is now accepted and ready to land.Jun 10 2020, 8:19 AM
Closed by commit rS362299: lockf(1): Add EXAMPLES section (authored by fernape). · Explain WhyJun 18 2020, 9:20 AM
This revision was automatically updated to reflect the committed changes.
fernape marked an inline comment as done.
fernape added a commit: rS362299: lockf(1): Add EXAMPLES section.

Revision Contents
Changeset List

PathSize
lockf/
22 lines

Diff 72918

View Options

lockf/lockf.1

Loading...