zfsbootcfg: use vfs.root.mountfrom and update nextboot on every vdev
ClosedPublic
Actions

Authored by tsoome on Jun 2 2020, 4:18 PM.

Details

Reviewers

allanjude
imp

Commits

rS361842: zfsbootcfg: use vfs.root.mountfrom and update nextboot on every vdev

Summary

vfs.zfs.boot.primary_pool is only set on BIOS boot, use vfs.root.mountfrom
instead and update all vdevs on pool.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31473
Build 29085: arc lint + arc unit

Event Timeline

tsoome requested review of this revision.Jun 2 2020, 4:18 PM

tsoome created this revision.

Harbormaster completed remote builds in B31442: Diff 72569.Jun 2 2020, 4:18 PM

allanjude added inline comments.Jun 2 2020, 6:23 PM

sbin/zfsbootcfg/zfsbootcfg.c
44	We should change the naming throughout zfsbootcfg to call it 'bootonce', since 'nextboot' is a different feature, and this will get confusing when we combine the two
55	Instead of doing this here, we can use the new IOCTL from upstream where looping over and writing to each label is done inside the kernel

As we progress here, we will want a switch to maintain the legacy behaviour, at least for a while. We might even decide not to change the default right away.

tsoome marked an inline comment as done.Jun 3 2020, 7:28 PM

tsoome added inline comments.