[new port] games/lolcat, a high performance C implementation of the famous lolcat
ClosedPublic
Actions

Authored by gbe on May 31 2020, 1:15 PM.

Details

Reviewers

pizzamig

Group Reviewers

Contributor Reviewers (ports)

Commits

rP542049: games/lolcat: new port, a C implementation of the famous lolcat

Summary

Add a port of lolcat, a high performance C implementation of the famous lolcat

Test Plan

make && make install

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 31467
Build 29079: arc lint + arc unit

Event Timeline

gbe requested review of this revision.May 31 2020, 1:15 PM

gbe created this revision.

Harbormaster completed remote builds in B31407: Diff 72473.May 31 2020, 1:15 PM

gbe added a reviewer: Contributor Reviewers (ports).May 31 2020, 1:16 PM

Moin moin

This needs to be wired into games/Makefile too.

mfg Tobias

games/lolcat/Makefile
4	git describe --tags a83e59dc25ba5430f7f79376d7c0f432ce27a6fe v1.0-9-ga83e59d So this could be DISTVERSIONPREFIX= v DISTVERSION=1.0-9 DISTVERSIONSUFFIX= -ga83e59d See [1] for more details. [1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex5 example 5.14
13	^is redundant (same as portname)
14	^ this can be removed, if you do the above distversion handling
games/lolcat/pkg-descr
3	pkg-descr should contain a WWW: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-desc.html

Add changes from the tcberner's feedback

Harbormaster completed remote builds in B31460: Diff 72615.Jun 3 2020, 3:31 PM

Mark findings as done.

Thanks for the changes so far.

games/lolcat/Makefile
17	^DIST* variables belong in the first block :) https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-order.html#porting-order-portname

Move DIST* make directives to the top and add a LICENSE block while here

Harbormaster completed remote builds in B31467: Diff 72629.Jun 3 2020, 6:27 PM

gbe added inline comments.Jun 3 2020, 6:27 PM

games/lolcat/Makefile
17	Ah, I missed this while I only had a quick read over the handbook. I correct this and upload a correct differential. Thank. :)

gbe marked an inline comment as done.Jun 3 2020, 6:28 PM

linimon retitled this revision from Add a port of lolcat, a high performance C implementation of the famous lolcat to [new port] games/lolcat, a high performance C implementation of the famous lolcat.Jun 26 2020, 8:17 AM

@tcberner ping?

Moin moin

There are two more issues:

Firstly:

[00:00:03] Warning: MOVED: games/lolcat renamed to games/rubygem-lolcat

Apparently there was previously a ruby-port with the same name which was later moved
=> You need to modify the MOVED file too.

Secondly:

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: /censor
Error: Orphaned: /lolcat

So it seems the port does not yet install files to the proper locations.

mfg Tobias

Few changes are needed to make portlint happy

games/lolcat/Makefile
4	CATEGORIES has to be places after all the DISTVERSION variables
5	This empty line has to be removed
11	porlint suggests to remove the initial 'A'. The comment could just be: "High performance implementation of the famous lolcat"

This revision now requires changes to proceed.Jul 11 2020, 3:18 PM

Fix portlint -A warnings and use my FreeBSD e-mail for the maintainership

Harbormaster completed remote builds in B32251: Diff 74321.Jul 11 2020, 6:05 PM

That leaves the

MOVED : remove entry
games/Makefile : add SUBDIR = lolcat
games/lolcat/Makefile fix up DESTDIR handling (lolcats Makefile uses DESTDIR which collides with DESTDIR from ports framework)