Put some ports back to the pool
ClosedPublic
Actions

Authored by salvadore on Jun 3 2020, 12:21 AM.

Details

Reviewers

gerald
tcberner

Commits

rP537855: Put some ports back in the pool

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 31452
Build 29068: arc lint + arc unit

Event Timeline

salvadore created this revision.Jun 3 2020, 12:21 AM

Herald added a subscriber: mat. · View Herald TranscriptJun 3 2020, 12:21 AM

salvadore requested review of this revision.Jun 3 2020, 12:21 AM

Harbormaster completed remote builds in B31452: Diff 72587.Jun 3 2020, 12:21 AM

I don't think updating maintainer needs bump PORTREVISION, does it?

lwhsu added reviewers: gerald, tcberner.Jun 3 2020, 4:27 AM

salvadore edited the test plan for this revision. (Show Details)Jun 3 2020, 8:22 AM

I think you are right about PORTREVISION and I removed the bumps.
I also added another port that I forgot.

And thanks for having set the reviewers correctly: I had put them in the
test plan by mistake. I guess I should avoid working on FreeBSD when I am
too sleepy :)

Harbormaster completed remote builds in B31456: Diff 72602.Jun 3 2020, 8:31 AM

lgtm

This revision is now accepted and ready to land.Jun 3 2020, 2:15 PM

This is definitely fine, Lorenzo.

You can also consider this kind of change pre-approved (and equally for you to adapt a port from ports@, but note that we preferably expect a maintainer change to come as part of a larger update).

And thanks for catching those two things, lwhsu@!

(I typed this in my lunch break, but failed to "Submit.")

Closed by commit rP537855: Put some ports back in the pool (authored by salvadore). · Explain WhyJun 3 2020, 9:54 PM

This revision was automatically updated to reflect the committed changes.

salvadore added a commit: rP537855: Put some ports back in the pool.