Page MenuHomeFreeBSD
Differential D24993

powerpc/pmap: Convert all PowerPC pmaps to use IFUNCs instead of kobj
ClosedPublic
Actions

Authored by jhibbits on May 25 2020, 3:21 AM.
Tags
None
Referenced Files
F135903610: D24993.id72211.diff
Fri, Nov 14, 12:30 AM
F135897625: D24993.id72211.diff
Thu, Nov 13, 11:13 PM
Unknown Object (File)
Tue, Nov 4, 3:28 PM
Unknown Object (File)
Wed, Oct 29, 9:23 AM
Unknown Object (File)
Wed, Oct 29, 9:23 AM
Unknown Object (File)
Wed, Oct 29, 9:23 AM
Unknown Object (File)
Wed, Oct 29, 9:23 AM
Unknown Object (File)
Wed, Oct 29, 3:07 AM
View All 89 Files
Subscribers
None

Details

Reviewers
nwhitehorn
bdragon
luporl
Group Reviewers
PowerPC
Summary

Since we have ifuncs in kernel now, use them for pmap, instead of our
poor-man's version of singleton kobjs. At the very least, this saves
one extra register stomp in the KPIs.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 31297
Build 28937: arc lint + arc unit

Event Timeline

jhibbits requested review of this revision.May 25 2020, 3:21 AM
jhibbits created this revision.
Harbormaster completed remote builds in B31282: Diff 72211.May 25 2020, 3:21 AM
jhibbits updated this revision to Diff 72247.May 25 2020, 6:32 PM

Fix bugs caused by my misunderstanding of how ifuncs work.

Harbormaster completed remote builds in B31297: Diff 72247.May 25 2020, 6:32 PM
bdragon mentioned this in rS361493: [PowerPC] Ensure ppc32 cpu_switch routines set up Secure-PLT..May 26 2020, 2:27 AM
jhibbits updated this revision to Diff 72280.May 26 2020, 2:06 PM

Apply to ps3.

Harbormaster completed remote builds in B31315: Diff 72280.May 26 2020, 2:06 PM
bdragon added a comment.May 26 2020, 8:49 PM

After a couple of days of debugging stuff to fix unrelated problems:

works on powerpc AIM32 (PowerPC G4)
works on powerpcspe (e500v2)
works on powerpc64 Book-E (e5500)

Have not tested AIM64 yet.

bdragon accepted this revision.May 27 2020, 12:58 AM

Tested in AIM64 (in my superglue branch, but should be a valid test anyway)

Also gave it a couple of skims through.

This revision is now accepted and ready to land.May 27 2020, 12:58 AM
jhibbits closed this revision.May 27 2020, 1:40 AM

Committed as r361544.

Revision Contents
Changeset List

PathSize
sys/
conf/
2 lines
powerpc/
aim/
340 lines
32 lines
598 lines
402 lines
87 lines
booke/
1 line
394 lines
114 lines
94 lines
include/
214 lines
1 line
powerpc/
3 lines
665 lines
ps3/
2 lines
pseries/
76 lines

Diff 72247

View Options

sys/conf/files.powerpc

Loading...
View Options

sys/powerpc/aim/mmu_oea.c

Loading...
View Options

sys/powerpc/aim/mmu_oea64.h

Loading...
View Options

sys/powerpc/aim/mmu_oea64.c

Loading...
View Options

sys/powerpc/aim/mmu_radix.c

Loading...
View Options

sys/powerpc/aim/moea64_if.m

Loading...
View Options

sys/powerpc/aim/moea64_native.c

Loading...
View Options

sys/powerpc/booke/booke_machdep.c

Loading...
View Options

sys/powerpc/booke/pmap.c

Loading...
View Options

sys/powerpc/booke/pmap_32.c

Loading...
View Options

sys/powerpc/booke/pmap_64.c

Loading...
View Options

sys/powerpc/include/mmuvar.h

Loading...
View Options

sys/powerpc/include/pmap.h

Loading...
View Options

sys/powerpc/powerpc/machdep.c

Loading...
View Options

sys/powerpc/powerpc/mmu_if.m

Loading...
View Options

sys/powerpc/powerpc/pmap_dispatch.c

Loading...
View Options

sys/powerpc/ps3/mmu_ps3.c

Loading...
View Options

sys/powerpc/pseries/mmu_phyp.c

Loading...