Page MenuHomeFreeBSD
Differential D24731

Add rib_lookup() sockaddr lookup wrapper and make ifa_ifwithroute use it.
ClosedPublic
Actions

Authored by melifaro on May 6 2020, 8:08 AM.
Tags
None
Referenced Files
F135999001: D24731.id71451.diff
Fri, Nov 14, 11:10 PM
Unknown Object (File)
Thu, Nov 13, 1:28 AM
Unknown Object (File)
Sun, Oct 26, 2:11 PM
Unknown Object (File)
Sun, Oct 26, 2:11 PM
Unknown Object (File)
Sun, Oct 26, 2:11 PM
Unknown Object (File)
Sun, Oct 26, 8:02 AM
Unknown Object (File)
Wed, Oct 22, 5:24 PM
Unknown Object (File)
Sat, Oct 18, 6:25 PM
View All 85 Files
Subscribers
ae
imp

Details

Reviewers
None
Group Reviewers
network
Commits
rS360773: Add rib_lookup() sockaddr lookup wrapper and make ifa_ifwithroute use it.
Summary

Create rib_lookup() wrapper around per-af dataplane lookup functions.
This will help in the cases of having control plane af-agnostic code.

Switch ifa_ifwithroute() to use this function instead of rtalloc1().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30944
Build 28655: arc lint + arc unit

Event Timeline

melifaro created this revision.May 6 2020, 8:08 AM
Herald added subscribers: ae, imp. · View Herald TranscriptMay 6 2020, 8:08 AM
melifaro requested review of this revision.May 6 2020, 8:08 AM
Harbormaster completed remote builds in B30944: Diff 71451.May 6 2020, 8:08 AM
ae added inline comments.May 6 2020, 9:07 AM
sys/net/route/route_helpers.c
113

We usually don't use tab after #ifdef, only after #define.

116

It seems & is not needed here.

124

The same.

melifaro marked 3 inline comments as done.May 7 2020, 8:10 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 8:12 AM
Closed by commit rS360773: Add rib_lookup() sockaddr lookup wrapper and make ifa_ifwithroute use it. (authored by melifaro). · Explain Why
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rS360773: Add rib_lookup() sockaddr lookup wrapper and make ifa_ifwithroute use it..

Revision Contents
Changeset List

PathSize
sys/
net/
2 lines
32 lines
route/
51 lines

Diff 71451

View Options

sys/net/route.h

Loading...
View Options

sys/net/route.c

Loading...
View Options

sys/net/route/route_helpers.c

Loading...