Page MenuHomeFreeBSD
Differential D24624

www/osrm-backend: Fix build on CURRENT and pet portlint
ClosedPublic
Actions

Authored by lbartoletti on Apr 29 2020, 7:20 PM.
Tags
None
Referenced Files
F82319317: D24624.diff
Sat, Apr 27, 3:20 PM
Unknown Object (File)
Sat, Apr 20, 5:27 PM
Unknown Object (File)
Tue, Apr 16, 5:43 PM
Unknown Object (File)
Mar 6 2024, 1:16 PM
Unknown Object (File)
Mar 6 2024, 1:15 PM
Unknown Object (File)
Mar 6 2024, 1:15 PM
Unknown Object (File)
Mar 6 2024, 1:15 PM
Unknown Object (File)
Mar 5 2024, 11:06 AM
View All 35 Files
Subscribers
mat

Details

Reviewers
tcberner
swills
Commits
rP535738: www/osrm-backend: Fix build on CURRENT and pet portlint
Summary

Fix build on CURRENT and pet portlint

Submitted by maintainer

Test Plan

porlint (looks fine.)
poudriere (11/12/HEAD i386/amd64)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 30808
Build 28531: arc lint + arc unit

Event Timeline

lbartoletti created this revision.Apr 29 2020, 7:20 PM
Herald added a subscriber: mat. · View Herald TranscriptApr 29 2020, 7:20 PM
lbartoletti requested review of this revision.Apr 29 2020, 7:20 PM
Harbormaster completed remote builds in B30799: Diff 71162.Apr 29 2020, 7:20 PM
tcberner added a comment.Apr 29 2020, 7:24 PM

I see why there are so many whitespace changes... but :D

www/osrm-backend/Makefile
41

why bsd.port.options.mk and not bsd.ports.pre.mk?

[1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-after-port-mk.html

lbartoletti marked an inline comment as done.Apr 30 2020, 1:27 PM
lbartoletti added inline comments.
www/osrm-backend/Makefile
41

My bad, I pushed his patch and not the fixed one

lbartoletti updated this revision to Diff 71183.Apr 30 2020, 1:35 PM
lbartoletti marked an inline comment as done.

Use bsd.ports.pre.mk instead of bsd.port.options.mk

Harbormaster completed remote builds in B30808: Diff 71183.Apr 30 2020, 1:35 PM
lbartoletti added a comment.May 16 2020, 6:06 AM

Can I ship it?

tcberner accepted this revision.May 17 2020, 7:23 PM

stlgtm

This revision is now accepted and ready to land.May 17 2020, 7:23 PM
Closed by commit rP535738: www/osrm-backend: Fix build on CURRENT and pet portlint (authored by lbartoletti). · Explain WhyMay 18 2020, 1:38 PM
This revision was automatically updated to reflect the committed changes.
lbartoletti added a commit: rP535738: www/osrm-backend: Fix build on CURRENT and pet portlint.

Revision Contents
Changeset List

PathSize
www/
osrm-backend/
65 lines

Diff 71183

View Options

www/osrm-backend/Makefile

Loading...