Don't run strcmp() against strings stored in user memory.
ClosedPublic
Actions

Authored by jhb on Apr 24 2020, 11:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 17, 11:21 AM

	Unknown Object (File)
	Sun, Mar 22, 7:36 AM

	Unknown Object (File)
	Sat, Mar 21, 5:13 PM

	Unknown Object (File)
	Mar 20 2026, 5:02 AM

	Unknown Object (File)
	Mar 20 2026, 5:02 AM

	Unknown Object (File)
	Mar 19 2026, 7:59 AM

	Unknown Object (File)
	Mar 19 2026, 7:27 AM

	Unknown Object (File)
	Mar 19 2026, 2:25 AM

View All 92 Files

Subscribers

imp

Details

Reviewers

brooks
kib

Commits

rS360388: Don't run strcmp() against strings stored in user memory.

Summary

Instead, copy the strings into a temporary buffer on the stack and
run strcmp on the copies.

Test Plan

compile tested only

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30716
Build 28445: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 24 2020, 11:50 PM

Harbormaster completed remote builds in B30716: Diff 70971.Apr 24 2020, 11:50 PM

kib accepted this revision.Apr 25 2020, 12:39 PM

This revision is now accepted and ready to land.Apr 25 2020, 12:39 PM

brooks accepted this revision.Apr 27 2020, 5:18 PM

Closed by commit rS360388: Don't run strcmp() against strings stored in user memory. (authored by jhb). · Explain WhyApr 27 2020, 6:04 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS360388: Don't run strcmp() against strings stored in user memory..

Herald added a subscriber: imp. · View Herald TranscriptApr 27 2020, 6:04 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

iscsi_initiator/

isc_subr.c

17 lines

Diff 70971

View Options

sys/dev/iscsi_initiator/isc_subr.c

Don't run strcmp() against strings stored in user memory.ClosedPublicActions