Page MenuHomeFreeBSD
Differential D3131

Add quirk for Thunder ITS GITS_BASER
ClosedPublic
Actions

Authored by zbb on Jul 20 2015, 5:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 11:18 AM
Unknown Object (File)
Sat, Nov 23, 7:13 AM
Unknown Object (File)
Wed, Nov 13, 10:42 PM
Unknown Object (File)
Tue, Nov 12, 10:50 PM
Unknown Object (File)
Tue, Nov 12, 4:50 PM
Unknown Object (File)
Tue, Nov 12, 1:52 PM
Unknown Object (File)
Tue, Nov 12, 11:14 AM
Unknown Object (File)
Tue, Nov 12, 11:10 AM
View All Files
Subscribers
andrew
emaste
imp

Details

Reviewers
emaste
andrew
wma_semihalf.com
Commits
rS286005: Add quirk for ThunderX ITS device table size
Summary

Thunder HW allows up to 0xFD pages in GITS_BASER[7:0] (size) field.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

wma_semihalf.com updated this revision to Diff 7089.Jul 20 2015, 5:12 AM
wma_semihalf.com retitled this revision from to Add quirk for Thunder ITS GITS_BASER.
wma_semihalf.com updated this object.
wma_semihalf.com edited the test plan for this revision. (Show Details)
wma_semihalf.com added reviewers: andrew, zbb, emaste.
wma_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptJul 20 2015, 5:12 AM
wma_semihalf.com updated this revision to Diff 7164.Jul 22 2015, 6:26 AM

Modified revision to sync with the Linux version of this quirk.

zbb accepted this revision.Jul 24 2015, 12:29 PM
zbb edited edge metadata.
zbb added inline comments.
sys/arm64/arm64/gic_v3_its.c
1375

Should be for bootverbose only.

This revision is now accepted and ready to land.Jul 24 2015, 12:29 PM
andrew added inline comments.Jul 27 2015, 9:18 PM
sys/arm64/arm64/gic_v3_its.c
135–136

This should have a comment explaining why it's needed.

andrew added inline comments.Jul 27 2015, 11:03 PM
sys/arm64/arm64/gic_v3_its.c
1377–1378

How is 13 bits 20MB?

zbb commandeered this revision.Jul 28 2015, 11:33 AM
zbb edited reviewers, added: wma_semihalf.com; removed: zbb.
This revision now requires review to proceed.Jul 28 2015, 11:33 AM
zbb updated this revision to Diff 7430.Jul 28 2015, 11:34 AM
zbb removed rS FreeBSD src repository - subversion as the repository for this revision.
zbb marked 3 inline comments as done.

I took over this revision. The patch should now contain proper numbers and detailed explanation.
Please comment or accept asap ;-)

wma_semihalf.com accepted this revision.Jul 28 2015, 12:04 PM
wma_semihalf.com edited edge metadata.
This revision is now accepted and ready to land.Jul 28 2015, 12:04 PM
Closed by commit rS286005: Add quirk for ThunderX ITS device table size (authored by zbb). · Explain WhyJul 29 2015, 11:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
16 lines

Diff 7089

View Options

sys/arm64/arm64/gic_v3_its.c

Loading...