make ctladm devlist, islist and portlist return 0 if everything wasok
ClosedPublic
Actions

Authored by bapt on Jul 15 2015, 3:57 PM.

Details

Reviewers

trasz
mav

Commits

rS286058: MFC r285928 Do not enable UDP checksum offloading when running on the
rS285929: make ctdladm(8) return 0 is everything was ok.
rS285658: make ctdladm(8) return 0 is everything was ok.

Summary

retval is used to test the return of XML_Parse function which is ok if 1 is
returned and retval it directly return the the main function and used as an exit
value

if all the parsing part is done reset retval to 0 so that the command return 0
if everything ok

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bapt updated this revision to Diff 6976.Jul 15 2015, 3:57 PM

bapt retitled this revision from to make ctladm devlist, islist and portlist return 0 if everything wasok.

bapt updated this object.

bapt edited the test plan for this revision. (Show Details)

bapt added reviewers: mva, trasz.

Herald added a subscriber: imp. · View Herald TranscriptJul 15 2015, 3:57 PM

Removed erronuously added empty new line

bapt edited reviewers, added: mav; removed: mva.Jul 15 2015, 4:12 PM

trasz accepted this revision.Jul 17 2015, 6:28 PM

trasz edited edge metadata.

This revision is now accepted and ready to land.Jul 17 2015, 6:28 PM

Closed by commit rS285658: make ctdladm(8) return 0 is everything was ok. (authored by bapt). · Explain WhyJul 17 2015, 7:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

ctladm/

ctladm.c

3 lines

Diff 7058

View Options

head/usr.sbin/ctladm/ctladm.c

make ctladm devlist, islist and portlist return 0 if everything wasokClosedPublicActions