Page MenuHomeFreeBSD
Differential D24397

lang/go-devel: Convert to slave of lang/go, apply D24122
ClosedPublic
Actions

Authored by dmgk on Apr 13 2020, 3:13 PM.
Tags
None
Referenced Files
F171245674: D24397.id70494.diff
Wed, Sep 9, 7:42 PM
Unknown Object (File)
Sat, Aug 22, 3:48 PM
Unknown Object (File)
Sat, Aug 22, 12:52 PM
Unknown Object (File)
Sat, Aug 22, 10:31 AM
Unknown Object (File)
Sat, Aug 22, 9:19 AM
Unknown Object (File)
Fri, Aug 21, 3:49 PM
Unknown Object (File)
Fri, Aug 21, 1:09 PM
Unknown Object (File)
Fri, Aug 21, 12:55 PM
View All Files
Subscribers
mat

Details

Reviewers
mikael
tobik
Commits
rP531626: lang/go-devel: Convert to a slave of lang/go, apply D24122
Summary
- Convert to slave port of lang/go
- Apply D24122 (similar to r530387 for lang/go) to relax module consistency
  checks in go1.14 mode
Test Plan

poudriere testport: OK for both lang/go and lang/go-devel

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 30456
Build 28213: arc lint + arc unit

Event Timeline

dmgk created this revision.Apr 13 2020, 3:13 PM
Herald added a subscriber: mat. · View Herald TranscriptApr 13 2020, 3:13 PM
Harbormaster completed remote builds in B30456: Diff 70494.Apr 13 2020, 3:13 PM
tobik added inline comments.Apr 13 2020, 3:56 PM
lang/go/Makefile
39–40

Unrelated to this review, but these are now flagged by portscan/portclippy. Can you drop them? Without setting SHEBANG_LANG=sh they are unused.

42

Overwrites the one from go-devel. Use ?=.

dmgk updated this revision to Diff 70500.Apr 13 2020, 4:14 PM
dmgk marked 2 inline comments as done.
  • remove sh*CMD
  • do not overwrite CONFLICTS_INSTALL
Harbormaster completed remote builds in B30462: Diff 70500.Apr 13 2020, 4:14 PM
tobik accepted this revision.Apr 13 2020, 4:19 PM

Thanks. One more nit but otherwise LGTM.

lang/go/Makefile
16

Oh, COMMENT also needs ?=.

This revision is now accepted and ready to land.Apr 13 2020, 4:19 PM
dmgk updated this revision to Diff 70502.Apr 13 2020, 4:28 PM
  • also leave COMMENT alone
This revision now requires review to proceed.Apr 13 2020, 4:28 PM
Harbormaster completed remote builds in B30463: Diff 70502.Apr 13 2020, 4:28 PM
dmgk marked an inline comment as done.Apr 13 2020, 4:29 PM
dmgk added inline comments.
lang/go/Makefile
16

Thanks for catching these.

dmgk marked an inline comment as done.Apr 13 2020, 4:31 PM
mikael accepted this revision.Apr 13 2020, 6:53 PM
This revision is now accepted and ready to land.Apr 13 2020, 6:53 PM
Closed by commit rP531626: lang/go-devel: Convert to a slave of lang/go, apply D24122 (authored by dmgk). · Explain WhyApr 13 2020, 7:16 PM
This revision was automatically updated to reflect the committed changes.
dmgk added a commit: rP531626: lang/go-devel: Convert to a slave of lang/go, apply D24122.

Revision Contents
Changeset List

PathSize
lang/
go-devel/
119 lines
2 lines
12 lines
go/
11 lines

Diff 70494

View Options

lang/go-devel/Makefile

Loading...
View Options

lang/go-devel/distinfo

Loading...
View Options

lang/go-devel/files/

Loading...
View Options

lang/go-devel/files/patch-src_cmd_go_internal_modload_init.go

Loading...
View Options

lang/go-devel/pkg-descr

Loading...
View Options

lang/go/Makefile

Loading...