Remove support for the algorithms deprecated in r348876.
ClosedPublic
Actions

Authored by jhb on Apr 8 2020, 10:09 PM.

Details

Reviewers

cem
jmg

Commits

rS360562: Remove support for the algorithms deprecated in r348876.

Summary

This removes support for the following algorithms:

ARC4
Blowfish
CAST128
DES
3DES
MD5-HMAC
Skipjack

Since /dev/crypto no longer supports 3DES, stop testing the 3DES KAT
vectors in cryptotest.py.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 30382
Build 28147: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 8 2020, 10:09 PM

Harbormaster completed remote builds in B30382: Diff 70360.Apr 8 2020, 10:09 PM

jhb added a parent revision: D24341: Deprecate 3des support in IPsec for FreeBSD 13..Apr 8 2020, 10:09 PM

I don't know why we would defer 3DES to 14. I think it makes more sense to remove it ASAP, and we should probably also go ahead and mark SHA1-HMAC as gone_in(14). NIST will probably unrecommend that one pretty soon.

(The removals are good and correct, thanks.)

This revision is now accepted and ready to land.Apr 9 2020, 3:01 AM

Remove 3des as well.

This revision now requires review to proceed.Apr 22 2020, 8:58 PM

Harbormaster completed remote builds in B30674: Diff 70896.Apr 22 2020, 8:59 PM

jhb retitled this revision from Remove support for most of the algorithms deprecated in r348876. to Remove support for the algorithms deprecated in r348876..Apr 22 2020, 8:59 PM

jhb edited the summary of this revision. (Show Details)

This revision was not accepted when it landed; it landed in state Needs Review.May 2 2020, 2:20 PM

Closed by commit rS360562: Remove support for the algorithms deprecated in r348876. (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS360562: Remove support for the algorithms deprecated in r348876..

Herald added a reviewer: jmg. · View Herald TranscriptMay 2 2020, 2:20 PM

Herald added a subscriber: imp. · View Herald Transcript