Allow the kernel to build with a compiler that sets -fno-common.
ClosedPublic
Actions

Authored by brooks on Apr 6 2020, 10:35 PM.

Tags

None

Referenced Files

	F106141160: D24322.diff
	Thu, Dec 26, 2:05 AM

	Unknown Object (File)
	Thu, Dec 12, 7:33 PM

	Unknown Object (File)
	Nov 24 2024, 1:33 AM

	Unknown Object (File)
	Nov 20 2024, 11:19 AM

	Unknown Object (File)
	Nov 18 2024, 10:37 AM

	Unknown Object (File)
	Nov 15 2024, 3:41 AM

	Unknown Object (File)
	Oct 28 2024, 1:51 PM

	Unknown Object (File)
	Sep 16 2024, 4:20 PM

View All 38 Files

Subscribers

None

Details

Reviewers

kevans
jhb
imp

Commits

rS359691: Allow the kernel to build with a compiler that sets -fno-common.

Summary

The mechanism that generates assym.inc and offset.inc depends on the
symbols in question being common. For now, simply force the object files
to be created with -fcommon.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Apr 6 2020, 10:35 PM

Harbormaster completed remote builds in B30334: Diff 70283.Apr 6 2020, 10:35 PM

I took a brief look at rewriting the awk to work with either -fcommon or -fno-common a lttle bit ago, but that's non-trivial as things don't line up as neatly.

This revision is now accepted and ready to land.Apr 6 2020, 10:38 PM

The values are also quite different if you diff the nm output. I think this whole thing will need to be rethought eventually, but removing -fcommon is probably a long ways off.

Closed by commit rS359691: Allow the kernel to build with a compiler that sets -fno-common. (authored by brooks). · Explain WhyApr 7 2020, 3:32 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS359691: Allow the kernel to build with a compiler that sets -fno-common..