Paths

Table of Contentst

Differential D24023

[PORT REVISION] Fix for ghc in CURRENT
ClosedPublic
Actions

Authored by github_evilham.com on Mar 11 2020, 10:30 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 12, 10:02 AM

	Unknown Object (File)
	Fri, Mar 29, 6:39 PM

	Unknown Object (File)
	Fri, Mar 29, 6:39 PM

	Unknown Object (File)
	Fri, Mar 29, 6:39 PM

	Unknown Object (File)
	Fri, Mar 29, 6:39 PM

	Unknown Object (File)
	Fri, Mar 29, 6:39 PM

	Unknown Object (File)
	Fri, Mar 29, 6:26 PM

	Unknown Object (File)
	Mar 18 2024, 11:47 AM

View All 63 Files

Subscribers

Details

Reviewers

Commits

rP528241: Follow-follow-up for r528190.

Summary

It looks like moving the patch after .include <bsd.port.pre.mk> made it not work in a way that I didn't notice yesterday.

This was the error message, maybe due to BUILD_DEPENDS= replacing that from USES=gmake:

****************************************************
Configuration done, ready to 'make install'
(see README and INSTALL files for more info.)
****************************************************
cd /wrkdirs/usr/ports/lang/ghc/work/ghc-8.6.5-boot && PACKAGES='' gmake install
/bin/sh: gmake: not found
*** Error code 127

Stop.
make: stopped in /usr/ports/lang/ghc
=>> Cleaning up wrkdir
===>  Cleaning for ghc-8.6.5_5
build of lang/ghc | ghc-8.6.5_5 ended at Wed Mar 11 10:55:58 CET 2020
build time: 00:00:22
!!! build failure encountered !!

Test Plan

Same as D24014.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 29879
Build 27699: arc lint + arc unit

Event Timeline

github_evilham.com created this revision.Mar 11 2020, 10:30 AM

Herald added a subscriber: mat. · View Herald TranscriptMar 11 2020, 10:30 AM

Harbormaster completed remote builds in B29876: Diff 69389.Mar 11 2020, 10:30 AM

From IRC feedback, don't bump revision.

Harbormaster completed remote builds in B29877: Diff 69390.Mar 11 2020, 10:34 AM

mikael added a subscriber: mikael.Mar 11 2020, 11:24 AM

mikael added inline comments.

lang/ghc/Makefile
88–89	Can you remove the ARCH check, it's also a problem on arm.

github_evilham.com added inline comments.Mar 11 2020, 11:31 AM

lang/ghc/Makefile
88–89	Sadly `misc/compat12x` only supports these archs ATM https://www.freshports.org/misc/compat12x/

mikael added inline comments.Mar 11 2020, 12:11 PM

lang/ghc/Makefile
88–89	Yes I know: https://reviews.freebsd.org/D24024

Remove arch check for the added misc/compat12x dependency.

If the that port is not available for a given arch, build may fail
anyway and D24024 adds support for other archs to misc/compat12x.

Harbormaster completed remote builds in B29879: Diff 69393.Mar 11 2020, 2:43 PM

github_evilham.com marked 2 inline comments as done.Mar 11 2020, 2:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 11 2020, 5:46 PM

Closed by commit rP528241: Follow-follow-up for r528190. (authored by arrowd). · Explain Why

This revision was automatically updated to reflect the committed changes.

arrowd added a commit: rP528241: Follow-follow-up for r528190..

Revision Contents
Changeset List

Path

Size

lang/

ghc/

4 lines

Diff 69393

lang/ghc/Makefile

Loading...