Page MenuHomeFreeBSD
Differential D2801

Add ATF tests for fstyp(8)
ClosedPublic
Actions

Authored by asomers on Jun 12 2015, 11:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 2:15 PM
Unknown Object (File)
Tue, Nov 5, 4:49 AM
Unknown Object (File)
Sat, Nov 2, 11:38 AM
Unknown Object (File)
Tue, Oct 29, 6:07 PM
Unknown Object (File)
Sun, Oct 27, 7:34 PM
Unknown Object (File)
Sun, Oct 27, 5:00 PM
Unknown Object (File)
Sep 27 2024, 4:48 AM
Unknown Object (File)
Sep 26 2024, 5:42 PM
View All Files
Subscribers
imp

Details

Reviewers
ngie
trasz
Commits
rS286964: Add ATF functional tests for fstyp(8). No ZFS or GELI tests yet.
Summary

Add ATF functional tests for fstyp(8)

Test Plan

"kyua test"

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

asomers updated this revision to Diff 6155.Jun 12 2015, 11:33 PM
asomers retitled this revision from to Add ATF tests for fstyp(8).
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added a reviewer: trasz.
Herald added a subscriber: imp. · View Herald TranscriptJun 12 2015, 11:33 PM
asomers updated this revision to Diff 6241.Jun 16 2015, 4:40 PM

Adding tests for multiple flavors of FAT.

trasz added a reviewer: ngie.Jun 17 2015, 8:41 AM

Looks ok to me, but I don't know ATF.

trasz added a comment.Jul 2 2015, 1:31 PM

Ping? Assuming it works (as in, if it passes, and if it correctly fails when you tweak the code to break it), could you commit it?

asomers added a comment.Jul 2 2015, 4:31 PM
In D2801#58321, @trasz wrote:

Ping? Assuming it works (as in, if it passes, and if it correctly fails when you tweak the code to break it), could you commit it?

If you're happy with it, I will. I was just waiting for ngie to review it.

On on vacation now; I'll get to this sometime next Wednesdayish.

ngie edited edge metadata.Jul 4 2015, 8:56 AM

General comments:

  • Use atf_check copiously to make sure that commands complete successfully.
  • Use mkdir -p a/b instead of mkdir a; mkdir a/b .
usr.sbin/fstyp/tests/fstyp_test.sh
9–10
  • mkdir -p dir/emptyfile
  • This should use atf_check to make sure the command executes cleanly
21–22

Same as above

asomers updated this revision to Diff 6926.Jul 14 2015, 6:17 PM
asomers edited edge metadata.

Address ngie's feedback. Use atf_check on almost every line except the ones
that need to redirect stdout, and condense "mkdir foo; mkdir foo/bar" to "mkdir
-p foo/bar".

asomers updated this revision to Diff 6931.Jul 14 2015, 7:43 PM

Fix permissions on fstyp_test.sh

trasz added a comment.Jul 18 2015, 11:49 AM

Ping?

ngie added inline comments.Jul 20 2015, 6:57 AM
usr.sbin/fstyp/tests/fstyp_test.sh
49

All references to zcat should use bzcat for portability..

asomers added inline comments.Jul 22 2015, 5:12 PM
usr.sbin/fstyp/Makefile
47

The extra diffs in this file are caused by svn r284589, which went in after I opened this review. I didn't actually change this file in diff 6926

usr.sbin/fstyp/tests/fstyp_test.sh
49

Whoops! I'm surprised that worked at all. I think I started working with gzipped images then switched to bzip2 for better compression. Fix on its way...

asomers updated this revision to Diff 7184.Jul 22 2015, 5:12 PM

s/zcat/bzcat

asomers added a comment.Aug 3 2015, 3:06 PM

Ping? Does my latest revision fix all review comments?

ngie accepted this revision.Aug 9 2015, 7:00 AM
ngie edited edge metadata.

LGTM -- thanks for all the hard work :)!

This revision is now accepted and ready to land.Aug 9 2015, 7:00 AM
Closed by commit rS286964: Add ATF functional tests for fstyp(8). No ZFS or GELI tests yet. (authored by asomers). · Explain WhyAug 20 2015, 3:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6931

View Options

etc/mtree/BSD.tests.dist

Loading...
View Options

usr.sbin/fstyp/Makefile

Loading...
View Options

usr.sbin/fstyp/tests/

Loading...
View Options

usr.sbin/fstyp/tests/Makefile

Loading...
View Options

usr.sbin/fstyp/tests/ext2.img.bz2

Loading...
View Options

usr.sbin/fstyp/tests/ext3.img.bz2

Loading...
View Options

usr.sbin/fstyp/tests/ext4.img.bz2

Loading...
View Options

usr.sbin/fstyp/tests/ext4_with_label.img.bz2

Loading...
View Options

usr.sbin/fstyp/tests/fstyp_test.sh

Loading...
View Options

usr.sbin/fstyp/tests/ntfs.img.bz2

Loading...
View Options

usr.sbin/fstyp/tests/ntfs_with_label.img.bz2

Loading...