Differential D23844

Bring in various kgdb fixes for powerpc.
ClosedPublic
Actions

Authored by jhb on Feb 26 2020, 7:02 PM.

Tags

None

Referenced Files

	F108126073: D23844.id68865.diff
	Tue, Jan 21, 4:12 PM

	Unknown Object (File)
	Tue, Dec 24, 3:22 AM

	Unknown Object (File)
	Dec 22 2024, 7:10 AM

	Unknown Object (File)
	Dec 21 2024, 11:46 AM

	Unknown Object (File)
	Nov 23 2024, 11:05 PM

	Unknown Object (File)
	Nov 22 2024, 8:34 AM

	Unknown Object (File)
	Nov 21 2024, 12:48 PM

	Unknown Object (File)
	Nov 20 2024, 10:44 PM

View All 100 Files

Subscribers

Details

Reviewers

Commits

rP527234: Bring in various kgdb fixes for powerpc.

Summary

This merges in several fixes for kgdb on powerpc including fixing
backtraces and cross-debugging support.

Submitted by: luporl

Test Plan

poudriere bulk on stable/12 amd64

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 29626
Build 27485: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 26 2020, 7:02 PM

Herald added subscribers: mat, emaste. · View Herald TranscriptFeb 26 2020, 7:02 PM

Harbormaster completed remote builds in B29626: Diff 68849.Feb 26 2020, 7:02 PM

I know GDB 9 is released and I have a branch of kgdb based on the 9.x branch but wanted to get these in first before doing a patch to update to 9.1.

The arm change is just a compiler warning fix for an unused variable.

devel/gdb/Makefile
33	Oops, we don't need this bit (though it doesn't hurt).

pizzamig added inline comments.Feb 26 2020, 9:06 PM

devel/gdb/Makefile
33	actually it hurts. Can you please revert it? PREFIX is the prefix for the ports. This setting is designed for the base. Practically, we are moving the debug dir from /usr/lib/debug , where the base's debug symbols are stored to /usr/local/lib/debug that do not exist.

pizzamig added inline comments.Feb 26 2020, 9:11 PM

devel/gdb/Makefile
33	ups, sorry, I'm wrong, you're adding it, not changing it. Good to me

Please commit it

This revision is now accepted and ready to land.Feb 26 2020, 9:26 PM

Closed by commit rP527234: Bring in various kgdb fixes for powerpc. (authored by jhb). · Explain WhyFeb 27 2020, 1:01 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rP527234: Bring in various kgdb fixes for powerpc..

luporl mentioned this in D21946: [PPC] Fix kgdb symbol resolution.Feb 27 2020, 12:30 PM

luporl mentioned this in D22761: [PPC] Fix register context fetch from pcb.

Revision Contents
Changeset List

Path

Size

devel/

gdb/

3 lines

files/

extrapatch-kgdb

86 lines

kgdb/

arm-fbsd-kern.c

2 lines

22 lines

78 lines

Diff 68849

devel/gdb/Makefile

Loading...

devel/gdb/files/extrapatch-kgdb

Loading...

devel/gdb/files/kgdb/arm-fbsd-kern.c

Loading...

devel/gdb/files/kgdb/fbsd-kvm.c

Loading...

devel/gdb/files/kgdb/ppcfbsd-kern.c

Loading...