x11-toolkits/p5-Alien-wxWidgets: remove extraneous escapes
post-patch phase of this port uses sed to replace 'wx-config with '${WX_CONFIG:T}. Previously it escaped the ', but this is not necessary in this context.
Remove the extraneous escape so that it doesn't get passed through to sed(1) as an escape of an ordinary character. This is important as the patch in bug #229925 will make such escapes an error to ease transition into a world where some escaped-ordinaries will be granted a special meaning.
This patch also contains a pkg-plist update to include Config/gtk_3* -- I do not know if this is correct, but it was needed to get through a poudriere testport so I've included it.
PR: 240450
Approved by: koobs (mentor) or bapt (mentor)
Approved by: portmgr (maintainer timeout: 4 months)
Differential_Revision: D23702Details
Details
- Reviewers
bapt koobs - Group Reviewers
Perl - Commits
- rP526585: MFH: r526580
rP526580: x11-toolkits/p5-Alien-wxWidgets: remove extraneous escapes
QA:
- portlint: OK (minor warnings that should be addressed separately.)
- testport: OK (poudriere: 12.0-RELEASE, amd64[*])
- Only minimal testing done because the nature of the patch would lead to arch-independent catastrophic meltdown
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
yes the missing file in the plist is right. Please bump portrevision before committing
Comment Actions
It would be good to have an explanation for the unexpected pkg-plist change, assuming its not influenced (confirmed with you on irc) or caused by the reinplace_cmd change
Comment Actions
Testing seems to indicate it was simply overlooked in a previous update. I'll commit this separately. tagged w/ MFH: 2020Q1, and a message like
x11-toolkits/p5-Alien-wxWidgets: add missing file to pkg-plist This appears to have been overlooked in a previous update, so note its presence in the pkg-plist. This fixes Q/A checks run by `poudriere testport`. MFH: 2020Q1 Reviewed by: koobs (mentor), bapt (mentor) Approved by: koobs (mentor), bapt (mentor)