The Porter's Handbook Go chapter: Document GO_TESTTARGET
ClosedPublic
Actions

Authored by dmgk on Nov 16 2019, 7:26 PM.

Details

Reviewers

tobik
mat
eadler

Group Reviewers

Doc Committers

Commits

rD53923: Porter's Handbook: Document GO_TESTTARGET and GO_TESTFLAGS

Diff Detail

Repository

rD FreeBSD doc repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 29510
Build 27380: arc lint + arc unit

Event Timeline

dmgk created this revision.Nov 16 2019, 7:26 PM

Herald added 1 blocking reviewer(s): mat. · View Herald TranscriptNov 16 2019, 7:26 PM

Harbormaster completed remote builds in B27584: Diff 64460.Nov 16 2019, 7:26 PM

eadler accepted this revision.Nov 17 2019, 2:44 AM

tobik accepted this revision.Nov 17 2019, 5:23 AM

No longer relevant/requires changes after rP518928.

dmgk abandoned this revision.Dec 5 2019, 11:31 AM

Hi Dmitri, do you plan to reclaim/commit this too after rP526567? @eadler already approved it before.

In D22413#522253, @tobik wrote:

Hi Dmitri, do you plan to reclaim/commit this too after rP526567? @eadler already approved it before.

I am, but doesn't this still need approval from @mat first?

Rename GO_TEST_TARGET to GO_TESTTARGET

Harbormaster completed remote builds in B29509: Diff 68591.Feb 20 2020, 1:48 PM

dmgk retitled this revision from The Porter's Handbook Go chapter: Document GO_TEST_TARGET to The Porter's Handbook Go chapter: Document GO_TESTTARGET.Feb 20 2020, 1:48 PM

In D22413#522269, @dmgk wrote:

In D22413#522253, @tobik wrote:

Hi Dmitri, do you plan to reclaim/commit this too after rP526567? @eadler already approved it before.

I am, but doesn't this still need approval from @mat first?

Thanks. I don't think so. You can commit to the doc repository if you have approval from a doc committer. @mat had opportunity before to comment on or veto it.

Oh, GO_TESTFLAGS needs to be documented too.

This revision now requires changes to proceed.Feb 20 2020, 1:56 PM