Page MenuHomeFreeBSD
Differential D23737

nat64: Get the IPv4 address from a NAT64 address when comparing addresses in a ICMP translate
AbandonedPublic
Actions

Authored by nc on Feb 17 2020, 9:43 PM.
Tags
Referenced Files
F136808316: D23737.id68489.diff
Wed, Nov 19, 5:25 PM
F136771862: D23737.id.diff
Wed, Nov 19, 10:32 AM
F136771860: D23737.id68545.diff
Wed, Nov 19, 10:32 AM
F136771854: D23737.id68476.diff
Wed, Nov 19, 10:32 AM
F136771847: D23737.id68488.diff
Wed, Nov 19, 10:32 AM
F136771145: D23737.id68488.vs68476.diff
Wed, Nov 19, 10:24 AM
F136767857: D23737.id.diff
Wed, Nov 19, 9:43 AM
Unknown Object (File)
Tue, Nov 18, 11:02 AM
View All Files
Subscribers
ae
freebsd-net-list
imp
melifaro
Contributor Reviews (src)

Details

Reviewers
ae
Summary

nat64: Get the IPv4 address from an IPv6 NAT64 address when comparing a source address with a destination address in an ICMP translate.

Submitted by: Neel Chauhan <neel AT neelc DOT org>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

nc created this revision.Feb 17 2020, 9:43 PM
Herald added subscribers: Contributor Reviews (src), melifaro, ae, imp. · View Herald TranscriptFeb 17 2020, 9:43 PM
ae requested changes to this revision.Feb 18 2020, 8:15 AM

The patch is not correct. IPv4 address can be embedded in different places depending from configuration.

This revision now requires changes to proceed.Feb 18 2020, 8:15 AM
nc updated this revision to Diff 68488.Feb 18 2020, 4:25 PM
nc edited the summary of this revision. (Show Details)

Here, I also compare the destination addresses. Is this what you want?

nc updated this revision to Diff 68489.Feb 18 2020, 4:38 PM
ae added a comment.Feb 19 2020, 11:26 AM
In D23737#521593, @neel_neelc.org wrote:

Here, I also compare the destination addresses. Is this what you want?

No, take a look at RFC 6052 p2.2..

ae added a comment.Feb 19 2020, 11:28 AM

Also, how did test your changes? :)
NAT64 currently is not widely used, thus changes here can break something and you will know about breakage when it will be not so easy to fix, e.g. after release.

nc updated this revision to Diff 68545.Feb 19 2020, 4:33 PM

I decided to use the existing function nat64_extract_ip4() to extract the IPv4 and removed my nat64_get_ip4().

I'm new to the FreeBSD TCP/IP stack, sorry.

nc abandoned this revision.Oct 12 2020, 10:39 PM

Revision Contents
Changeset List

PathSize
sys/
netpfil/
ipfw/
nat64/
11 lines

Diff 68545

View Options

sys/netpfil/ipfw/nat64/nat64_translate.c

Loading...