Page MenuHomeFreeBSD
Differential D23620

Add 50G-KR4 media type.
ClosedPublic
Actions

Authored by kib on Feb 11 2020, 2:23 PM.
Tags
None
Referenced Files
F136951961: D23620.id68117.diff
Thu, Nov 20, 7:48 PM
F136951709: D23620.id68116.diff
Thu, Nov 20, 7:47 PM
F136950905: D23620.id68113.diff
Thu, Nov 20, 7:43 PM
F136950175: D23620.id.diff
Thu, Nov 20, 7:40 PM
F136950099: D23620.id68124.diff
Thu, Nov 20, 7:39 PM
F136948317: D23620.diff
Thu, Nov 20, 7:28 PM
Unknown Object (File)
Tue, Nov 18, 9:53 PM
Unknown Object (File)
Mon, Nov 3, 12:16 PM
View All Files
Subscribers
ae
imp

Details

Reviewers
• hselasky
Commits
rS357765: if_media.h: Add 50G KR4 ethernet media type.
rS357764: if_media.c: staticize and constify ifmedia description structures used under…
rS357763: if_media.c: use __FBSDID().
Summary

Also do some (un)related fixes in if_media.c. These will be committed separately.

Submitted by: Adam Peace <adam.e.peace@gmail.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Feb 11 2020, 2:23 PM
Herald added subscribers: ae, imp. · View Herald TranscriptFeb 11 2020, 2:23 PM
Harbormaster completed remote builds in B29292: Diff 68113.Feb 11 2020, 2:23 PM
• hselasky accepted this revision.Feb 11 2020, 2:29 PM
• hselasky added inline comments.
sys/net/if_media.c
395 ↗(On Diff #68113)

Should this perhaps be "static const" ?

This revision is now accepted and ready to land.Feb 11 2020, 2:29 PM
• hselasky added a comment.Feb 11 2020, 2:30 PM

Don't forget to MFC

kib updated this revision to Diff 68116.Feb 11 2020, 2:54 PM

Constify.

This revision now requires review to proceed.Feb 11 2020, 2:54 PM
Harbormaster completed remote builds in B29293: Diff 68116.Feb 11 2020, 2:54 PM
kib updated this revision to Diff 68117.Feb 11 2020, 2:55 PM

Push the right patch.

Harbormaster completed remote builds in B29294: Diff 68117.Feb 11 2020, 2:56 PM
• hselasky accepted this revision.Feb 11 2020, 2:56 PM
This revision is now accepted and ready to land.Feb 11 2020, 2:56 PM
Closed by commit rS357763: if_media.c: use __FBSDID(). (authored by kib). · Explain WhyFeb 11 2020, 5:41 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rS357763: if_media.c: use __FBSDID()..
kib added a commit: rS357764: if_media.c: staticize and constify ifmedia description structures used under….Feb 11 2020, 5:45 PM
kib added a commit: rS357765: if_media.h: Add 50G KR4 ethernet media type..Feb 11 2020, 6:03 PM

Revision Contents
Changeset List

PathSize
head/
sys/
net/
4 lines

Diff 68124

View Options

head/sys/net/if_media.c

Loading...