x11/lumina: Update to 1.6.0 and Take MAINTAINER'ship
ClosedPublic
Actions

Authored by lbartoletti on Feb 10 2020, 4:32 PM.

Details

Reviewers

tcberner
swills

Commits

rP526736: x11/lumina: Update to 1.6.0 and Take MAINTAINER'ship

Summary

x11/lumina, x11/lumina-core,
x11/lumina-coreutils,
deskutils/lumina-fileinfo,
deskutils/lumina-calculator,
deskutils/lumina-fm,
deskutils/lumina-screenshot,
deskutils/lumina-textedit,
deskutils/lumina-archiver,
deskutils/lumina-photo,
deskutils/lumina-mediaplayer,
deskutils/lumina-pdf: Update to 1.6.0

Take MAINTAINER'ship
Update to 1.6.0

Changelog:

Lumina: https://github.com/lumina-desktop/lumina/compare/v1.5.0...v1.6.0 Lumina-pdf: https://github.com/lumina-desktop/lumina-pdf/compare/v1.5.0...v1.6.0 Lumina-calculator: https://github.com/lumina-desktop/lumina-calculator/compare/v1.5.0...v1.6.0

Test Plan

portlint: OK (looks fine.)
testport: OK (poudriere: 11/12/13, i386/amd64)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 29271
Build 27185: arc lint + arc unit

Event Timeline

lbartoletti created this revision.Feb 10 2020, 4:32 PM

Herald added a subscriber: mat. · View Herald TranscriptFeb 10 2020, 4:32 PM

Harbormaster completed remote builds in B29271: Diff 68064.Feb 10 2020, 4:32 PM

Did you ask Ken?

In D23603#517995, @tcberner wrote:

Did you ask Ken?

Yes, both on telegram chat

In D23603#518103, @lbartoletti_tuxfamily.org wrote:

In D23603#517995, @tcberner wrote:

Did you ask Ken?

Yes, both on telegram chat

Macro stlgtm:

[00:05:26] [01] [00:00:33] Finished deskutils/lumina-textedit | lumina-textedit-1.6.0: Failed: check-plist

could you please double check that?

This revision now requires changes to proceed.Feb 10 2020, 8:23 PM

In D23603#518173, @tcberner wrote:
[00:05:26] [01] [00:00:33] Finished deskutils/lumina-textedit | lumina-textedit-1.6.0: Failed: check-plist
could you please double check that?

Ah la boulette... - Imgur.gif (212×350 px, 1 MB)

Done and pet portlint

Fix deskutils/lumina-textedit pkg-plist
Pet portlint with USE_GL and USES={xorg, gl}

Harbormaster completed remote builds in B29301: Diff 68135.Feb 11 2020, 8:11 PM

mat added inline comments.Feb 12 2020, 2:32 PM

deskutils/lumina-archiver/Makefile
18	You need `USES=gl`.
22–30	Wrong place in the Makefile, it is framework variables, then options. See Chapter 15. Order of Variables in Port Makefiles.
deskutils/lumina-calculator/Makefile
21–29	Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.
deskutils/lumina-fileinfo/Makefile
18	You need `USES=gl`.
22–30	Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.
deskutils/lumina-fm/Makefile
16	`USES=gl`.
20–28	Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.
deskutils/lumina-mediaplayer/Makefile
26–32	Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.
deskutils/lumina-pdf/Makefile
32–34	Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.
deskutils/lumina-photo/Makefile
16	`USES=gl`.
23	Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.
deskutils/lumina-screenshot/Makefile
25–27	Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.
deskutils/lumina-textedit/Makefile
18	Why `+=`?
25–27	Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.
x11/lumina-core/Makefile
44–47	Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.
x11/lumina-coreutils/Makefile
28–30	Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.