Page MenuHomeFreeBSD

x11/lumina: Update to 1.6.0 and Take MAINTAINER'ship
Needs ReviewPublic

Authored by lbartoletti_tuxfamily.org on Mon, Feb 10, 4:32 PM.

Details

Reviewers
tcberner
swills
Summary

x11/lumina, x11/lumina-core,
x11/lumina-coreutils,
deskutils/lumina-fileinfo,
deskutils/lumina-calculator,
deskutils/lumina-fm,
deskutils/lumina-screenshot,
deskutils/lumina-textedit,
deskutils/lumina-archiver,
deskutils/lumina-photo,
deskutils/lumina-mediaplayer,
deskutils/lumina-pdf: Update to 1.6.0

Test Plan
  • portlint: OK (looks fine.)
  • testport: OK (poudriere: 11/12/13, i386/amd64)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 29301
Build 27206: arc lint + arc unit

Event Timeline

Did you ask Ken?

Did you ask Ken?

Yes, both on telegram chat

Did you ask Ken?

Yes, both on telegram chat

Macro stlgtm:

tcberner requested changes to this revision.Mon, Feb 10, 8:23 PM
[00:05:26] [01] [00:00:33] Finished deskutils/lumina-textedit | lumina-textedit-1.6.0: Failed: check-plist

could you please double check that?

This revision now requires changes to proceed.Mon, Feb 10, 8:23 PM
[00:05:26] [01] [00:00:33] Finished deskutils/lumina-textedit | lumina-textedit-1.6.0: Failed: check-plist

could you please double check that?

Done and pet portlint

Fix deskutils/lumina-textedit pkg-plist
Pet portlint with USE_GL and USES={xorg, gl}

mat added inline comments.Wed, Feb 12, 2:32 PM
deskutils/lumina-archiver/Makefile
18

You need USES=gl.

23–31

Wrong place in the Makefile, it is framework variables, then options. See Chapter 15. Order of Variables in Port Makefiles.

deskutils/lumina-calculator/Makefile
21–29

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

deskutils/lumina-fileinfo/Makefile
18

You need USES=gl.

23–31

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

deskutils/lumina-fm/Makefile
16

USES=gl.

21–29

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

deskutils/lumina-mediaplayer/Makefile
26–32

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

deskutils/lumina-pdf/Makefile
33–35

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

deskutils/lumina-photo/Makefile
16

USES=gl.

24

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

deskutils/lumina-screenshot/Makefile
32–34

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

deskutils/lumina-textedit/Makefile
18

Why +=?

26–28

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

x11/lumina-core/Makefile
44–47

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

x11/lumina-coreutils/Makefile
28–30

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.