Tidy the _set_tp function for RISC-V.
ClosedPublic
Actions

Authored by jhb on Feb 5 2020, 9:58 PM.

Tags

None

Referenced Files

	F171421240: D23521.diff
	Fri, Sep 11, 1:20 AM

	Unknown Object (File)
	Sat, Sep 5, 11:21 AM

	Unknown Object (File)
	Fri, Sep 4, 6:42 AM

	Unknown Object (File)
	Thu, Sep 3, 6:39 PM

	Unknown Object (File)
	Wed, Sep 2, 4:59 AM

	Unknown Object (File)
	Wed, Sep 2, 12:23 AM

	Unknown Object (File)
	Tue, Sep 1, 1:15 PM

	Unknown Object (File)
	Mon, Aug 31, 5:24 AM

View All Files

Subscribers

imp

Details

Reviewers

mhorne
jrtc27

Commits

rS357643: Tidy the _set_tp function for RISC-V.

Summary

Use a constant for the offset instead of a magic number.
Use an addi instruction that writes to tp directly instead of a mv that writes the result of a compiler-generated addi.

Test Plan

booted a new world in qemu, ran /usr/tests/lib/libc/tls/* tests

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Feb 5 2020, 9:58 PM

Harbormaster completed remote builds in B29190: Diff 67835.Feb 5 2020, 9:58 PM

mhorne accepted this revision.Feb 6 2020, 7:44 PM

This revision is now accepted and ready to land.Feb 6 2020, 7:44 PM

Closed by commit rS357643: Tidy the _set_tp function for RISC-V. (authored by jhb). · Explain WhyFeb 6 2020, 9:46 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS357643: Tidy the _set_tp function for RISC-V..

Herald added a subscriber: imp. · View Herald TranscriptFeb 6 2020, 9:46 PM

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

riscv/

gen/

_set_tp.c

7 lines

Diff 67901

View Options

head/lib/libc/riscv/gen/_set_tp.c

Tidy the _set_tp function for RISC-V.ClosedPublicActions