Page MenuHomeFreeBSD
Differential D23535

Improve implementation of install-missing-packages
ClosedPublic
Actions

Authored by 0mp on Feb 6 2020, 9:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 17, 2:18 PM
Unknown Object (File)
Sat, Jan 10, 3:01 AM
Unknown Object (File)
Fri, Jan 9, 10:51 AM
Unknown Object (File)
Sun, Jan 4, 5:31 PM
Unknown Object (File)
Nov 27 2025, 8:04 AM
Unknown Object (File)
Nov 24 2025, 11:55 AM
Unknown Object (File)
Nov 21 2025, 8:49 AM
Unknown Object (File)
Nov 21 2025, 8:49 AM
View All Files
Subscribers
adamw
bapt

Details

Reviewers
mat
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Commits
rP525388: Improve implementation of install-missing-packages
Summary
Improve implementation of install-missing-packages

As suggested by mat@ in D23484, let's use a proper if statement here instead of
short-circuits operators.
Test Plan

Run make install-missing-packages in:

  • a port which has all the dependencies already installed
  • a port which is still missing some dependencies

Try all the above scenarios with the default SU_CMD and with SU_CMD= /usr/local/bin/sudo -E sh -c.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 29203
Build 27130: arc lint + arc unit

Event Timeline

0mp created this revision.Feb 6 2020, 9:59 AM
Owners added a reviewer: O5: Ports Framework.Feb 6 2020, 9:59 AM
Herald added a reviewer: portmgr. · View Herald TranscriptFeb 6 2020, 9:59 AM
Harbormaster completed remote builds in B29203: Diff 67858.Feb 6 2020, 9:59 AM
mat accepted this revision as: portmgr.Feb 6 2020, 3:52 PM
mat added inline comments.Feb 6 2020, 3:56 PM
Mk/bsd.port.mk
4336

Ah, no, I knew I saw something I did not like. Quote what you pass to echo.

$$(${ECHO} "$${_dirs}"
0mp planned changes to this revision.Feb 6 2020, 4:07 PM
0mp added inline comments.
Mk/bsd.port.mk
4336

I should also use "ECHO_CMD" instead, right?

mat added inline comments.Feb 6 2020, 4:30 PM
Mk/bsd.port.mk
4336

yes

This revision was not accepted when it landed; it landed in state Changes Planned.Feb 6 2020, 4:44 PM
Closed by commit rP525388: Improve implementation of install-missing-packages (authored by 0mp). · Explain Why
This revision was automatically updated to reflect the committed changes.
0mp added a commit: rP525388: Improve implementation of install-missing-packages.
0mp added a comment.Feb 6 2020, 4:45 PM

Thanks, @mat! :)))

Revision Contents
Changeset List

PathSize
Mk/
5 lines

Diff 67858

View Options

Mk/bsd.port.mk

Loading...