Tidy the _set_tp function for RISC-V.
ClosedPublic
Actions

Authored by jhb on Feb 5 2020, 9:58 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jun 26, 9:09 PM

	Unknown Object (File)
	May 18 2024, 3:04 PM

	Unknown Object (File)
	Mar 19 2024, 2:00 PM

	Unknown Object (File)
	Jan 6 2024, 4:44 PM

	Unknown Object (File)
	Dec 20 2023, 6:41 AM

	Unknown Object (File)
	Nov 10 2023, 1:44 AM

	Unknown Object (File)
	Nov 8 2023, 1:40 AM

	Unknown Object (File)
	Nov 6 2023, 10:41 AM

View All 20 Files

Subscribers

imp

Details

Reviewers

mhorne
jrtc27

Commits

rS357643: Tidy the _set_tp function for RISC-V.

Summary

Use a constant for the offset instead of a magic number.
Use an addi instruction that writes to tp directly instead of a mv that writes the result of a compiler-generated addi.

Test Plan

booted a new world in qemu, ran /usr/tests/lib/libc/tls/* tests

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 29190
Build 27121: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 5 2020, 9:58 PM

Harbormaster completed remote builds in B29190: Diff 67835.Feb 5 2020, 9:58 PM

mhorne accepted this revision.Feb 6 2020, 7:44 PM

This revision is now accepted and ready to land.Feb 6 2020, 7:44 PM

Closed by commit rS357643: Tidy the _set_tp function for RISC-V. (authored by jhb). · Explain WhyFeb 6 2020, 9:46 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS357643: Tidy the _set_tp function for RISC-V..

Herald added a subscriber: imp. · View Herald TranscriptFeb 6 2020, 9:46 PM

Revision Contents
Changeset List

Path

Size

lib/

libc/

riscv/

gen/

_set_tp.c

7 lines

Diff 67835

View Options

lib/libc/riscv/gen/_set_tp.c

Tidy the _set_tp function for RISC-V.ClosedPublicActions