Read the breakpoint instruction to determine its length in BKPT_SKIP.
ClosedPublic
Actions

Authored by jhb on Feb 4 2020, 11:46 PM.

Tags

None

Referenced Files

	F172234805: D23507.id67799.diff
	Thu, Sep 17, 2:52 AM

	Unknown Object (File)
	Tue, Sep 15, 11:13 AM

	Unknown Object (File)
	Thu, Sep 10, 9:27 PM

	Unknown Object (File)
	Thu, Sep 10, 10:59 AM

	Unknown Object (File)
	Thu, Sep 10, 8:05 AM

	Unknown Object (File)
	Tue, Sep 8, 9:06 PM

	Unknown Object (File)
	Tue, Sep 8, 9:03 PM

	Unknown Object (File)
	Mon, Sep 7, 8:59 AM

View All Files

Subscribers

imp

Details

Reviewers

mhorne
br

Commits

rS357591: Read the breakpoint instruction to determine its length in BKPT_SKIP.

Summary

This fixes continuing from debug.kdb.enter=1 after enabling the use
of compressed instructions since the compiler can emit the two byte
c.ebreak instead of the 4 byte ebreak.

Test Plan

sysctl debug.kdb.enter and then 'c' to continue

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 29171
Build 27103: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 4 2020, 11:46 PM

Harbormaster completed remote builds in B29171: Diff 67799.Feb 4 2020, 11:46 PM

br accepted this revision.Feb 5 2020, 5:50 PM

This revision is now accepted and ready to land.Feb 5 2020, 5:50 PM

Closed by commit rS357591: Read the breakpoint instruction to determine its length in BKPT_SKIP. (authored by jhb). · Explain WhyFeb 5 2020, 8:06 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS357591: Read the breakpoint instruction to determine its length in BKPT_SKIP..

Herald added a subscriber: imp. · View Herald TranscriptFeb 5 2020, 8:06 PM

Revision Contents
Changeset List

Path

Size

sys/

riscv/

include/

db_machdep.h

10 lines

Diff 67799

View Options

sys/riscv/include/db_machdep.h

Read the breakpoint instruction to determine its length in BKPT_SKIP.ClosedPublicActions