Differential D23495

Fix a recursion in thread_create().
ClosedPublic
Actions

Authored by jeff on Feb 3 2020, 10:06 PM.

Tags

None

Referenced Files

	F152449548: D23495.diff
	Wed, Apr 15, 1:12 AM

	F152446853: D23495.id67745.diff
	Wed, Apr 15, 12:44 AM

	Unknown Object (File)
	Sat, Apr 11, 10:44 PM

	Unknown Object (File)
	Fri, Apr 10, 5:38 AM

	Unknown Object (File)
	Mon, Apr 6, 4:39 PM

	Unknown Object (File)
	Mon, Mar 30, 10:27 AM

	Unknown Object (File)
	Mon, Mar 30, 4:03 AM

	Unknown Object (File)
	Sat, Mar 28, 10:33 AM

Subscribers

Details

Reviewers

kib
markj
mjg

Commits

rS357486: Fix a recursion on the thread lock by acquiring it after call rtp_to_pri().

Summary

I'm not even sure who to ask about this one. This was a bug as a result of removing recursion from thread_lock(). It looks like the sched_prio() is not really necessary as rtp will do it in the important cases but it may miss setting user_pri until the first userret. I don't think this is a problem.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29149
Build 27085: arc lint + arc unit

Event Timeline

jeff created this revision.Feb 3 2020, 10:06 PM

Harbormaster completed remote builds in B29149: Diff 67745.Feb 3 2020, 10:06 PM

jeff edited the summary of this revision. (Show Details)Feb 3 2020, 10:07 PM

jeff added reviewers: kib, markj, mjg.

jeff set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptFeb 3 2020, 10:07 PM

kib accepted this revision.Feb 3 2020, 10:35 PM

This revision is now accepted and ready to land.Feb 3 2020, 10:35 PM

markj accepted this revision.Feb 3 2020, 11:06 PM

Closed by commit rS357486: Fix a recursion on the thread lock by acquiring it after call rtp_to_pri(). (authored by jeff). · Explain WhyFeb 4 2020, 2:43 AM

This revision was automatically updated to reflect the committed changes.

jeff added a commit: rS357486: Fix a recursion on the thread lock by acquiring it after call rtp_to_pri()..

Revision Contents
Changeset List

Path

Size

sys/

kern/

12 lines

Diff 67745

sys/kern/kern_thr.c

Loading...