Page MenuHomeFreeBSD
Differential D23492

Fix the !SMP case in sched_add().
ClosedPublic
Actions

Authored by markj on Feb 3 2020, 8:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 18, 5:07 PM
Unknown Object (File)
Tue, Dec 16, 11:56 AM
Unknown Object (File)
Sat, Dec 13, 9:23 PM
Unknown Object (File)
Thu, Dec 11, 8:58 PM
Unknown Object (File)
Nov 24 2025, 6:13 PM
Unknown Object (File)
Nov 20 2025, 8:45 PM
Unknown Object (File)
Nov 20 2025, 8:36 PM
Unknown Object (File)
Nov 20 2025, 8:36 PM
View All 98 Files
Subscribers
imp

Details

Reviewers
jeff
kib
Commits
rS357473: Fix the !SMP case in sched_add() after r355779.
Summary

If the thread's lock is already that of the runqueue, don't recurse on
the queue lock.

Test Plan

Fixes a panic on boot that I hit while trying to reproduce an unrelated problem.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29146
Build 27082: arc lint + arc unit

Event Timeline

markj created this revision.Feb 3 2020, 8:33 PM
Harbormaster completed remote builds in B29146: Diff 67741.Feb 3 2020, 8:33 PM
markj edited the test plan for this revision. (Show Details)Feb 3 2020, 8:35 PM
markj added reviewers: jeff, kib.
kib accepted this revision.Feb 3 2020, 8:43 PM
This revision is now accepted and ready to land.Feb 3 2020, 8:43 PM
jeff accepted this revision.Feb 3 2020, 10:17 PM

I thought I tested !SMP but maybe I just built it. This LGTM.

Looking at this I should really just add srqflags to thread_lock_set and possibly something similar to thread_lock_block().

Closed by commit rS357473: Fix the !SMP case in sched_add() after r355779. (authored by markj). · Explain WhyFeb 3 2020, 10:49 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS357473: Fix the !SMP case in sched_add() after r355779..
Herald added a subscriber: imp. · View Herald TranscriptFeb 3 2020, 10:49 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
12 lines

Diff 67741

View Options

sys/kern/sched_ule.c

Loading...