Differential D23470

databases/grass7: add SONAME and use new path for graphics/qgis*
ClosedPublic
Actions

Authored by lbartoletti on Feb 2 2020, 12:49 PM.

Tags

None

Referenced Files

	F175686869: D23470.id.diff
	Mon, Oct 12, 1:05 PM

	F175686678: D23470.id67883.diff
	Mon, Oct 12, 1:02 PM

	Unknown Object (File)
	Sep 2 2026, 10:24 PM

	Unknown Object (File)
	Sep 2 2026, 2:21 PM

	Unknown Object (File)
	Aug 31 2026, 12:12 AM

	Unknown Object (File)
	Aug 28 2026, 1:09 PM

	Unknown Object (File)
	Aug 23 2026, 2:26 AM

	Unknown Object (File)
	Aug 23 2026, 2:26 AM

Subscribers

Details

Reviewers

tcberner
swills

Commits

rP525400: databases/grass7: add SONAME and use new path for graphics/qgis*

Summary

databases/grass7: add SONAME and use new path for graphics/qgis*

Add SONAME (upstreamed) [1]
Remove the (bad) idea to keep a symlink to the old path logic (grass-M.m.b)
Fix FindGRASS.cmake for graphics/qgis and graphics/qgis-ltr (upstreamed) [2]

[1] https://github.com/OSGeo/grass/pull/301 [2] https://github.com/qgis/QGIS/pull/34088

Test Plan

portlint: OK (unrevelant warnings)
testport: OK (poudriere: 11/12/13, i386/amd64) [1]

[1] for databases/grass7 only 12amd64 for graphics/qgis and graphics/qgis-ltr

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 29110
Build 27052: arc lint + arc unit

Event Timeline

lbartoletti created this revision.Feb 2 2020, 12:49 PM

Herald added a subscriber: mat. · View Herald TranscriptFeb 2 2020, 12:49 PM

Harbormaster completed remote builds in B29110: Diff 67663.Feb 2 2020, 12:49 PM

From https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243736
Approved by Rainer Hurlin (maintainer)

Looks good to me.

graphics/qgis/files/patch-cmake_FindGRASS.cmake
10	^ Unrelated to this review: you should probably sed in the value of ${LOCALBASE} instead of a hardcoded /usr/local.

This revision is now accepted and ready to land.Feb 4 2020, 6:37 AM

lbartoletti added inline comments.Feb 4 2020, 9:25 AM

graphics/qgis/files/patch-cmake_FindGRASS.cmake
10	I wonder if we can replace it by CMAKE_INSTALL_PREFIX instead.

lbartoletti marked an inline comment as done.Feb 6 2020, 8:22 AM

lbartoletti added inline comments.

graphics/qgis/files/patch-cmake_FindGRASS.cmake
10	It works, but it's a bad idea :)

Closed by commit rP525400: databases/grass7: add SONAME and use new path for graphics/qgis* (authored by lbartoletti). · Explain WhyFeb 6 2020, 7:17 PM

This revision was automatically updated to reflect the committed changes.

lbartoletti added a commit: rP525400: databases/grass7: add SONAME and use new path for graphics/qgis*.

Revision Contents
Changeset List

Path

Size

databases/

grass7/

7 lines

files/

patch-aclocal.m4

10 lines

patch-configure

10 lines

1 line

graphics/

qgis-ltr/

2 lines

files/

patch-cmake_FindGRASS.cmake

13 lines

qgis/

2 lines

files/

patch-cmake_FindGRASS.cmake

13 lines

Diff 67663

databases/grass7/Makefile

Loading...

databases/grass7/files/patch-aclocal.m4

Loading...

databases/grass7/files/patch-configure

Loading...

databases/grass7/pkg-plist

Loading...

graphics/qgis-ltr/Makefile

Loading...

graphics/qgis-ltr/files/patch-cmake_FindGRASS.cmake

Loading...

graphics/qgis/Makefile

Loading...

graphics/qgis/files/patch-cmake_FindGRASS.cmake

Loading...