Page MenuHomeFreeBSD

databases/grass7: add SONAME and use new path for graphics/qgis*
ClosedPublic

Authored by lbartoletti on Feb 2 2020, 12:49 PM.

Details

Summary

databases/grass7: add SONAME and use new path for graphics/qgis*

Test Plan
  • portlint: OK (unrevelant warnings)
  • testport: OK (poudriere: 11/12/13, i386/amd64) [1]

[1] for databases/grass7 only 12amd64 for graphics/qgis and graphics/qgis-ltr

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 29110
Build 27052: arc lint + arc unit

Event Timeline

lbartoletti created this revision.Feb 2 2020, 12:49 PM
tcberner accepted this revision.Feb 4 2020, 6:37 AM

Looks good to me.

graphics/qgis/files/patch-cmake_FindGRASS.cmake
10

^ Unrelated to this review: you should probably sed in the value of ${LOCALBASE} instead of a hardcoded /usr/local.

This revision is now accepted and ready to land.Feb 4 2020, 6:37 AM
lbartoletti added inline comments.Feb 4 2020, 9:25 AM
graphics/qgis/files/patch-cmake_FindGRASS.cmake
10

I wonder if we can replace it by CMAKE_INSTALL_PREFIX instead.

lbartoletti marked an inline comment as done.Feb 6 2020, 8:22 AM
lbartoletti added inline comments.
graphics/qgis/files/patch-cmake_FindGRASS.cmake
10

It works, but it's a bad idea :)