Page MenuHomeFreeBSD
Differential D23422

vfs: replace VOP_MARKATIME with VOP_MMAPPED
ClosedPublic
Actions

Authored by mjg on Jan 30 2020, 4:22 AM.
Tags
None
Referenced Files
F156529050: D23422.id67489.diff
Thu, May 14, 11:03 AM
Unknown Object (File)
Wed, May 13, 2:44 PM
Unknown Object (File)
Wed, May 13, 9:08 AM
Unknown Object (File)
Thu, May 7, 12:55 PM
Unknown Object (File)
Sun, May 3, 11:48 PM
Unknown Object (File)
Sun, May 3, 1:03 PM
Unknown Object (File)
Mon, Apr 27, 12:44 AM
Unknown Object (File)
Mar 31 2026, 1:03 PM
View All Files
Subscribers
imp

Details

Reviewers
jeff
kib
jhb
Commits
rS357361: vfs: replace VOP_MARKATIME with VOP_MMAPPED
Summary

The routine is only provided by ufs and is only used on mmap and exec.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mjg created this revision.Jan 30 2020, 4:22 AM
Herald added a subscriber: imp. · View Herald TranscriptJan 30 2020, 4:22 AM
Harbormaster completed remote builds in B29030: Diff 67489.Jan 30 2020, 4:22 AM
kib accepted this revision.Jan 30 2020, 8:31 PM
kib added a reviewer: jhb.

I do not object, I also added John who was the author of the vfs_mark_atime().

sys/ufs/ufs/ufs_vnops.c
685 ↗(On Diff #67489)

It is nice to follow style(9) and avoid initialization in local declarations.

This revision is now accepted and ready to land.Jan 30 2020, 8:31 PM
mjg added a comment.Jan 30 2020, 9:13 PM

So the motivation is D23423

Closed by commit rS357361: vfs: replace VOP_MARKATIME with VOP_MMAPPED (authored by mjg). · Explain WhyFeb 1 2020, 6:47 AM
This revision was automatically updated to reflect the committed changes.
mjg added a commit: rS357361: vfs: replace VOP_MARKATIME with VOP_MMAPPED.

Revision Contents
Changeset List

PathSize
head/
sys/
kern/
2 lines
17 lines
4 lines
sys/
1 line
ufs/
ufs/
23 lines
vm/
2 lines

Diff 67603

View Options

head/sys/kern/kern_exec.c

Loading...
View Options

head/sys/kern/vfs_subr.c

Loading...
View Options

head/sys/kern/vnode_if.src

Loading...
View Options

head/sys/sys/vnode.h

Loading...
View Options

head/sys/ufs/ufs/ufs_vnops.c

Loading...
View Options

head/sys/vm/vm_mmap.c

Loading...