add INUSE flag to x86 fpu routines
ClosedPublic
Actions

Authored by jmg on Jul 7 2015, 4:21 PM.

Details

Reviewers

kib
eri
gnn

Commits

rS285290: Now that aesni won't reuse fpu contexts (D3016), add seatbelts to the

Summary

This adds an inuse flag to the fpu_ctx so that multiple threads
cannot use the same fpu_ctx possibly corrupting the other... This
enforces the requirement only when INVARIANTS is compiled, and
has been verified to catch this incorrect usage...

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

jmg updated this revision to Diff 6755.Jul 7 2015, 4:21 PM

jmg retitled this revision from to add INUSE flag to amd64's fpu.

jmg updated this object.

jmg edited the test plan for this revision. (Show Details)

jmg added reviewers: kib, gnn, eri.

Herald added a subscriber: imp. · View Herald TranscriptJul 7 2015, 4:21 PM

remove ifdef INVARIANTS, and add i386 support..

jmg retitled this revision from add INUSE flag to amd64's fpu to add INUSE flag to x86 fpu routines.Jul 7 2015, 5:44 PM

kib accepted this revision.Jul 8 2015, 9:33 AM

kib edited edge metadata.

This revision is now accepted and ready to land.Jul 8 2015, 9:33 AM

gnn accepted this revision.Jul 8 2015, 1:17 PM

gnn edited edge metadata.

jmg mentioned this in rS285289: address an issue where consumers, like IPsec, can reuse the same.Jul 8 2015, 7:15 PM

Closed by commit rS285290: Now that aesni won't reuse fpu contexts (D3016), add seatbelts to the (authored by jmg). · Explain WhyJul 8 2015, 7:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

fpu.c

13 lines

i386/

isa/

npx.c

12 lines

Diff 6757

View Options

sys/amd64/amd64/fpu.c