Paths

Table of Contentst

Differential D23188

textproc/txt2tags: Update to 3.4, fix graphics/qgis and graphics/qgis-ltr with this newest version
ClosedPublic
Actions

Authored by lbartoletti on Jan 15 2020, 7:11 AM.

Tags

None

Referenced Files

	F82425685: D23188.id66771.diff
	Sun, Apr 28, 1:19 PM

	Unknown Object (File)
	Fri, Apr 26, 1:43 PM

	Unknown Object (File)
	Thu, Apr 25, 12:28 PM

	Unknown Object (File)
	Wed, Apr 24, 5:53 PM

	Unknown Object (File)
	Wed, Apr 24, 5:53 PM

	Unknown Object (File)
	Wed, Apr 24, 5:53 PM

	Unknown Object (File)
	Wed, Apr 24, 5:53 PM

	Unknown Object (File)
	Wed, Apr 24, 5:40 PM

View All 69 Files

Subscribers

Details

Reviewers

tcberner
swills

Commits

rP523934: textproc/txt2tags: Update to 3.4, fix graphics/qgis and graphics/qgis-ltr with…

Summary

textproc/txt2tags: Update to 3.4, fix graphics/qgis and graphics/qgis-ltr with this newest version

Use python3 only [1]
Fix graphics/qgis and graphics/qgis-ltr with txt2tags-3.4 (remove --css-sugar --css-inside) [2][3]

Changelog:

https://github.com/txt2tags/txt2tags/blob/v3/CHANGELOG.md

[1] txt2tags v3 can use python2 too. But, only graphics/qgis* uses it and depends on python3. I want to avoid adding dependencies. And python2 is dead, isn't it? ;) [2] https://github.com/txt2tags/txt2tags#feature-differences-between-versions [3] https://github.com/qgis/QGIS/issues/33516

Test Plan

QA:

portlint: OK (looks fine.)
testport: OK (poudriere: 11, 12, 13 / i386, amd64)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lbartoletti created this revision.Jan 15 2020, 7:11 AM

Herald added a subscriber: mat. · View Herald TranscriptJan 15 2020, 7:11 AM

Harbormaster completed remote builds in B28682: Diff 66771.Jan 15 2020, 7:11 AM

tcberner added inline comments.Jan 18 2020, 9:27 PM

graphics/qgis-ltr/Makefile
153 ↗	(On Diff #66771)	^why do this in a loop? `... ${WRKSRC}/doc/INSTALL ${WRKSRC }/doc/news`

lbartoletti marked an inline comment as done.Jan 19 2020, 8:21 AM

lbartoletti added inline comments.

graphics/qgis-ltr/Makefile
153 ↗	(On Diff #66771)	Just a habit to iterate when there are several files to modify :) I'll fix that.

Remove the loop

Harbormaster completed remote builds in B28810: Diff 67092.Jan 21 2020, 9:29 AM

Looks good to me.

This revision is now accepted and ready to land.Jan 22 2020, 6:53 PM

Closed by commit rP523934: textproc/txt2tags: Update to 3.4, fix graphics/qgis and graphics/qgis-ltr with… (authored by lbartoletti). · Explain WhyJan 23 2020, 3:40 PM

This revision was automatically updated to reflect the committed changes.

lbartoletti added a commit: rP523934: textproc/txt2tags: Update to 3.4, fix graphics/qgis and graphics/qgis-ltr with….

mat added inline comments.Jan 23 2020, 3:54 PM

head/graphics/qgis-ltr/Makefile
151–153	The only replacements allowed with sed are variable replacements. All static changes have to be put into patches. See 4.4.3. Simple Automatic Replacements

lbartoletti mentioned this in D23602: graphics/qgis-ltr, graphics/qgis: Fix build after textproc/txt2tags update.Feb 10 2020, 4:09 PM

lbartoletti mentioned this in rP526917: graphics/qgis-ltr, graphics/qgis: Fix build after textproc/txt2tags update.Feb 23 2020, 11:03 AM

Revision Contents
Changeset List

Path

Size

head/

graphics/

qgis-ltr/

3 lines

qgis/

3 lines

textproc/

txt2tags/

16 lines

6 lines

Diff 67201

head/graphics/qgis-ltr/Makefile

Loading...

head/graphics/qgis/Makefile

Loading...

head/textproc/txt2tags/Makefile

Loading...

head/textproc/txt2tags/distinfo

Loading...