Page MenuHomeFreeBSD

textproc/txt2tags: Update to 3.4, fix graphics/qgis and graphics/qgis-ltr with this newest version
ClosedPublic

Authored by lbartoletti on Jan 15 2020, 7:11 AM.

Details

Summary

textproc/txt2tags: Update to 3.4, fix graphics/qgis and graphics/qgis-ltr with this newest version

Test Plan

QA:

  • portlint: OK (looks fine.)
  • testport: OK (poudriere: 11, 12, 13 / i386, amd64)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 28682
Build 26704: arc lint + arc unit

Event Timeline

lbartoletti created this revision.Jan 15 2020, 7:11 AM
tcberner added inline comments.Jan 18 2020, 9:27 PM
graphics/qgis-ltr/Makefile
153

^why do this in a loop?

... ${WRKSRC}/doc/INSTALL ${WRKSRC }/doc/news

lbartoletti marked an inline comment as done.Jan 19 2020, 8:21 AM
lbartoletti added inline comments.
graphics/qgis-ltr/Makefile
153

Just a habit to iterate when there are several files to modify :)
I'll fix that.

lbartoletti marked an inline comment as done.

Remove the loop

tcberner accepted this revision.Jan 22 2020, 6:53 PM

Looks good to me.

This revision is now accepted and ready to land.Jan 22 2020, 6:53 PM
mat added inline comments.Jan 23 2020, 3:54 PM
head/graphics/qgis-ltr/Makefile
151–153 ↗(On Diff #67201)

The only replacements allowed with sed are variable replacements. All static changes have to be put into patches. See 4.4.3. Simple Automatic Replacements