Differential D23294

Remove support for auto-selecting an external binutils.
ClosedPublic
Actions

Authored by jhb on Jan 21 2020, 8:42 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Aug 14, 6:16 AM

	Unknown Object (File)
	Thu, Aug 13, 6:35 PM

	Unknown Object (File)
	Wed, Aug 12, 2:04 PM

	Unknown Object (File)
	Wed, Aug 12, 8:10 AM

	Unknown Object (File)
	Mon, Aug 10, 4:16 PM

	Unknown Object (File)
	Mon, Aug 10, 3:58 PM

	Unknown Object (File)
	Mon, Aug 10, 3:52 PM

	Unknown Object (File)
	Sat, Aug 8, 3:03 PM

Subscribers

Details

Reviewers

emaste
imp

Commits

rS356996: Remove support for auto-selecting an external binutils.

Summary

All of the in-tree architectures not supported by in-tree binutils are
supported by lld, so the condition is now always false. It also
didn't fully work since the external binutils are installed into a
directory that uses the host's OS version, not the target OS version.

Test Plan

make tinderbox

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28809
Build 26817: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 21 2020, 8:42 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 21 2020, 8:42 AM

Harbormaster completed remote builds in B28809: Diff 67091.Jan 21 2020, 8:42 AM

Glad to see we can get rid of this. Thanks for cleaning it up.

This revision is now accepted and ready to land.Jan 21 2020, 12:15 PM

emaste accepted this revision.Jan 21 2020, 1:20 PM

I've updated my local version of D23124 with this change

Closed by commit rS356996: Remove support for auto-selecting an external binutils. (authored by jhb). · Explain WhyJan 22 2020, 9:21 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS356996: Remove support for auto-selecting an external binutils..

Revision Contents
Changeset List

Path

Size

18 lines

Diff 67091

Makefile.inc1

Loading...