vfs: refactor vnode allocation
ClosedPublic
Actions

Authored by mjg on Jan 13 2020, 8:44 PM.

Tags

None

Referenced Files

	F173312549: D23158.id66869.diff
	Fri, Sep 25, 4:39 AM

	F173312510: D23158.id66700.diff
	Fri, Sep 25, 4:38 AM

	F173312163: D23158.diff
	Fri, Sep 25, 4:36 AM

	F173311510: D23158.diff
	Fri, Sep 25, 4:31 AM

	Unknown Object (File)
	Thu, Sep 24, 7:05 AM

	Unknown Object (File)
	Sun, Sep 20, 5:29 AM

	Unknown Object (File)
	Aug 26 2026, 3:49 AM

	Unknown Object (File)
	Aug 24 2026, 11:56 AM

Subscribers

Details

Reviewers

kib
jeff

Commits

rS356811: vfs: refcator vnode allocation

Summary

Semantics are preserved. One benefit is that there are fewer accesses to both numvnodes and freevnodes.

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

I do not object to this patch but I would be more comfortable with kib reviewing.

This revision is now accepted and ready to land.Jan 15 2020, 11:45 PM

kib accepted this revision.Jan 16 2020, 2:01 PM

kib added inline comments.

sys/kern/vfs_subr.c
1508 ↗	(On Diff #66700)	Small change is that cyclecount was zeroed before when numvnodes < desiredvnodes.
1537 ↗	(On Diff #66700)	Style recommends putting binary op on the previous line.
1545 ↗	(On Diff #66700)	You can unlock vnode_list_mtx before wakeup.