Page MenuHomeFreeBSD
Differential D23158

vfs: refactor vnode allocation
ClosedPublic
Actions

Authored by mjg on Jan 13 2020, 8:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 6, 2:08 AM
Unknown Object (File)
Tue, Mar 3, 6:32 PM
Unknown Object (File)
Sat, Feb 28, 1:57 PM
Unknown Object (File)
Sat, Feb 28, 8:21 AM
Unknown Object (File)
Thu, Feb 12, 12:20 AM
Unknown Object (File)
Jan 21 2026, 5:42 PM
Unknown Object (File)
Jan 21 2026, 5:41 PM
Unknown Object (File)
Dec 30 2025, 9:52 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
jeff
Commits
rS356811: vfs: refcator vnode allocation
Summary

Semantics are preserved. One benefit is that there are fewer accesses to both numvnodes and freevnodes.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mjg created this revision.Jan 13 2020, 8:44 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 13 2020, 8:44 PM
Harbormaster completed remote builds in B28644: Diff 66700.Jan 13 2020, 8:44 PM
mjg added a child revision: D23140: vfs: increment numvnodes without the vnode list lock unless under pressure.Jan 13 2020, 8:47 PM
jeff accepted this revision.Jan 15 2020, 11:45 PM

I do not object to this patch but I would be more comfortable with kib reviewing.

This revision is now accepted and ready to land.Jan 15 2020, 11:45 PM
kib accepted this revision.Jan 16 2020, 2:01 PM
kib added inline comments.
sys/kern/vfs_subr.c
1508 ↗(On Diff #66700)

Small change is that cyclecount was zeroed before when numvnodes < desiredvnodes.

1537 ↗(On Diff #66700)

Style recommends putting binary op on the previous line.

1545 ↗(On Diff #66700)

You can unlock vnode_list_mtx before wakeup.

Closed by commit rS356811: vfs: refcator vnode allocation (authored by mjg). · Explain WhyJan 16 2020, 9:43 PM
This revision was automatically updated to reflect the committed changes.
mjg added a commit: rS356811: vfs: refcator vnode allocation.

Revision Contents
Changeset List

PathSize
head/
sys/
kern/
152 lines

Diff 66869

View Options

head/sys/kern/vfs_subr.c

Loading...