Differential D23158

vfs: refactor vnode allocation
ClosedPublic
Actions

Authored by mjg on Jan 13 2020, 8:44 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 21, 5:42 PM

	Unknown Object (File)
	Wed, Jan 21, 5:41 PM

	Unknown Object (File)
	Tue, Dec 30, 9:52 AM

	Unknown Object (File)
	Tue, Dec 30, 9:52 AM

	Unknown Object (File)
	Tue, Dec 30, 9:52 AM

	Unknown Object (File)
	Mon, Dec 29, 4:51 AM

	Unknown Object (File)
	Sun, Dec 28, 11:51 AM

	Unknown Object (File)
	Sun, Dec 28, 11:51 AM

Subscribers

Details

Reviewers

kib
jeff

Commits

rS356811: vfs: refcator vnode allocation

Summary

Semantics are preserved. One benefit is that there are fewer accesses to both numvnodes and freevnodes.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mjg created this revision.Jan 13 2020, 8:44 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 13 2020, 8:44 PM

Harbormaster completed remote builds in B28644: Diff 66700.Jan 13 2020, 8:44 PM

mjg added a child revision: D23140: vfs: increment numvnodes without the vnode list lock unless under pressure.Jan 13 2020, 8:47 PM

I do not object to this patch but I would be more comfortable with kib reviewing.

This revision is now accepted and ready to land.Jan 15 2020, 11:45 PM

kib accepted this revision.Jan 16 2020, 2:01 PM

kib added inline comments.

sys/kern/vfs_subr.c
1508 ↗	(On Diff #66700)	Small change is that cyclecount was zeroed before when numvnodes < desiredvnodes.
1537 ↗	(On Diff #66700)	Style recommends putting binary op on the previous line.
1545 ↗	(On Diff #66700)	You can unlock vnode_list_mtx before wakeup.

Closed by commit rS356811: vfs: refcator vnode allocation (authored by mjg). · Explain WhyJan 16 2020, 9:43 PM

This revision was automatically updated to reflect the committed changes.

mjg added a commit: rS356811: vfs: refcator vnode allocation.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

152 lines

Diff 66869

head/sys/kern/vfs_subr.c

Loading...