Page MenuHomeFreeBSD

vfs: refactor vnode allocation
ClosedPublic

Authored by mjg on Jan 13 2020, 8:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 7, 3:04 AM
Unknown Object (File)
Thu, Jul 2, 4:47 AM
Unknown Object (File)
Wed, Jul 1, 2:35 PM
Unknown Object (File)
Mon, Jun 29, 8:26 PM
Unknown Object (File)
Sat, Jun 27, 12:46 AM
Unknown Object (File)
Mon, Jun 22, 9:05 PM
Unknown Object (File)
Sun, Jun 21, 6:46 PM
Unknown Object (File)
Sat, Jun 20, 11:56 PM
Subscribers

Details

Summary

Semantics are preserved. One benefit is that there are fewer accesses to both numvnodes and freevnodes.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 28644

Event Timeline

I do not object to this patch but I would be more comfortable with kib reviewing.

This revision is now accepted and ready to land.Jan 15 2020, 11:45 PM
kib added inline comments.
sys/kern/vfs_subr.c
1508

Small change is that cyclecount was zeroed before when numvnodes < desiredvnodes.

1537

Style recommends putting binary op on the previous line.

1545

You can unlock vnode_list_mtx before wakeup.

This revision was automatically updated to reflect the committed changes.