uma: fixup some ktr messages
ClosedPublic
Actions

Authored by rlibby on Jan 12 2020, 8:04 PM.

Details

Reviewers

jeff
markj

Commits

rS356715: uma: fixup some ktr messages

Summary

Fixup some ktr format issues noticed in a recent debugging session.

Test Plan

make buildkernel

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28628
Build 26660: arc lint + arc unit

markj added inline comments.

sys/vm/uma_core.c
3525–3526	I think curthread is somewhat redundant since KTR always logs thread IDs. ... ah, I see it is in other KTR messages, so we should at least be consistent.

This revision is now accepted and ready to land.Jan 12 2020, 8:20 PM

sys/vm/uma_core.c
3525–3526	Yes. Although, it looks like there are only 4 others. We could fix those not to print thread instead? How thread is printed in uma_core.c is kind of weird anyway ("%x"). Separately it looks like ktr_tracepoint/ktr_verbose doesn't print the thread. I don't know if we care to change that.

sys/vm/uma_core.c
3525–3526	I'd be fine with dropping the thread from the KTR messages. I think they used to be plain printf()s and were converted mechanically, which would explain why they're there. Hmm, I don't think I've ever used ktr_verbose before. I agree that it should print the thread pointer as well.