Differential D22997

6/7 vfs: rework vnode list management
ClosedPublic
Actions

Authored by mjg on Jan 1 2020, 10:58 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jul 22, 7:46 PM

	Unknown Object (File)
	Tue, Jul 22, 5:03 PM

	Unknown Object (File)
	Tue, Jul 22, 5:02 PM

	Unknown Object (File)
	Tue, Jul 22, 4:57 PM

	Unknown Object (File)
	Tue, Jul 22, 4:19 PM

	Unknown Object (File)
	Tue, Jul 22, 3:41 PM

	Unknown Object (File)
	Mon, Jul 7, 8:48 AM

	Unknown Object (File)
	Fri, Jul 4, 11:56 AM

Subscribers

Details

Reviewers

kib
jeff
mckusick

Commits

rS356672: vfs: rework vnode list management

Summary

The current notion of an active vnode is eliminated.

Vnodes transition between 0<->1 hold counts all the time and the
associated traversal between different lists induces significant
scalability problems in certain workloads.

Introduce a global list containing all allocated vnodes. They get
unlinked only when UMA reclaims memory and are only requeued when
use hold count reaches 0.

Sample result from an incremental make -s -j 104 bzImage on tmpfs:
stock: 118.55s user 3649.73s system 7479% cpu 50.382 total
patched: 122.38s user 1780.45s system 6242% cpu 30.480 total

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mjg created this revision.Jan 1 2020, 10:58 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 1 2020, 10:58 PM

Harbormaster completed remote builds in B28424: Diff 66226.Jan 1 2020, 10:58 PM

mjg mentioned this in D21667: vfs: fix incorrect hold in vtryrecycle.Jan 1 2020, 11:02 PM

mjg mentioned this in D22694: [wip] vfs: defer vdrop if mnt_listmtx is contended.Jan 1 2020, 11:05 PM

mjg mentioned this in D22690: vfs: add MNT_VNODE_FOREACH_ACTIVE_FILTER.

mjg mentioned this in D21692: vfs: do lockless vnode checks in vlrureclaim.

I see why my previous comments about list duplication were not totally germane because much of the duplicated code was removed by this diff.

mjg mentioned this in D22995: 4/7 vfs: add per-mount vnode lazy list and use it for deferred inactive + msync.Jan 2 2020, 8:57 PM

rebase

mjg retitled this revision from 4/5 vfs: rework vnode list management to 6/7 vfs: rework vnode list management.Jan 5 2020, 4:07 AM

mjg mentioned this in D23067: vfs: reimplement vlrureclaim to actually use LRU.Jan 7 2020, 5:08 PM

rebase
annotate freevnodes with __exclusive_cache_line

rebase

jeff accepted this revision.Jan 12 2020, 7:55 PM

This revision is now accepted and ready to land.Jan 12 2020, 7:55 PM

Closed by commit rS356672: vfs: rework vnode list management (authored by mjg). · Explain WhyJan 13 2020, 2:37 AM

This revision was automatically updated to reflect the committed changes.

mjg added a commit: rS356672: vfs: rework vnode list management.

Revision Contents
Changeset List

Path

Size

sys/

fs/

msdosfs/

msdosfs_vfsops.c

2 lines

nfsserver/

2 lines

tmpfs/

2 lines

unionfs/

2 lines

kern/

8 lines

487 lines

sys/

18 lines

7 lines

ufs/

ufs/

4 lines

Diff 66627

sys/fs/msdosfs/msdosfs_vfsops.c

Loading...

sys/fs/nfsserver/nfs_nfsdport.c

Loading...

sys/fs/tmpfs/tmpfs_vfsops.c

Loading...

sys/fs/unionfs/union_vnops.c

Loading...

sys/kern/vfs_mount.c

Loading...

sys/kern/vfs_subr.c

Loading...

sys/sys/mount.h

Loading...

sys/sys/vnode.h

Loading...

sys/ufs/ufs/ufs_quota.c

Loading...