Add stricter checking on mac key lengths.
ClosedPublic
Actions

Authored by jhb on Jan 8 2020, 8:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 22, 3:49 PM

	Unknown Object (File)
	Tue, Sep 22, 3:30 PM

	Unknown Object (File)
	Wed, Sep 16, 5:06 AM

	Unknown Object (File)
	Sat, Sep 12, 10:20 PM

	Unknown Object (File)
	Fri, Sep 11, 1:29 AM

	Unknown Object (File)
	Sun, Sep 6, 8:46 PM

	Unknown Object (File)
	Sun, Sep 6, 8:02 AM

	Unknown Object (File)
	Sun, Sep 6, 6:05 AM

View All Files

Subscribers

imp

Details

Reviewers

cem
jmg

Commits

rS356561: Add stricter checking on mac key lengths.

Summary

Negative lengths are always invalid. The key length should also
be zero for hash algorithms that do not accept a key.

Test Plan

cryptocheck passes
test program that provokes a panic with a length of -1 now fails with an error

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 28555
Build 26605: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 8 2020, 8:01 PM

Harbormaster completed remote builds in B28555: Diff 66518.Jan 8 2020, 8:01 PM

cem accepted this revision.Jan 9 2020, 12:35 AM

This revision is now accepted and ready to land.Jan 9 2020, 12:35 AM

Closed by commit rS356561: Add stricter checking on mac key lengths. (authored by jhb). · Explain WhyJan 9 2020, 6:30 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS356561: Add stricter checking on mac key lengths..

Herald added a reviewer: jmg. · View Herald TranscriptJan 9 2020, 6:30 PM

Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

sys/

opencrypto/

cryptodev.c

4 lines

Diff 66518

View Options

sys/opencrypto/cryptodev.c

Add stricter checking on mac key lengths.ClosedPublicActions