Page MenuHomeFreeBSD
Differential D23036

2/7 vfs: reimplement deferred inactive
ClosedPublic
Actions

Authored by mjg on Jan 5 2020, 3:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 21, 4:03 PM
Unknown Object (File)
Sat, Jun 20, 1:53 PM
Unknown Object (File)
Thu, Jun 18, 8:18 PM
Unknown Object (File)
Mon, Jun 15, 2:43 AM
Unknown Object (File)
Fri, Jun 12, 11:51 PM
Unknown Object (File)
Wed, Jun 10, 8:54 PM
Unknown Object (File)
May 20 2026, 10:43 PM
Unknown Object (File)
May 7 2026, 11:02 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
jeff
mckusick
Commits
rS356441: vfs: reimplement deferred inactive to use a dedicated flag (VI_DEFINACT)
Summary

Previous behavior of leaving VI_OWEINACT vnodes on the active list without a hold count is eliminated. Instead, hold count is kept and inactive processing gets explicitly deferred by setting the VI_DEFINACT flag. The syncer is then responsible for vdrop.

This is taken out of D22995

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 28487

Event Timeline

mjg created this revision.Jan 5 2020, 3:45 AM
Herald added a subscriber: imp. · View Herald TranscriptJan 5 2020, 3:45 AM
Harbormaster completed remote builds in B28487: Diff 66363.Jan 5 2020, 3:45 AM
mjg mentioned this in D22995: 4/7 vfs: add per-mount vnode lazy list and use it for deferred inactive + msync.Jan 5 2020, 4:02 AM
mjg added a parent revision: D23035: 1/7 vfs: trylock in vfs_msync and refactor the func.Jan 5 2020, 4:04 AM
mjg retitled this revision from vfs: reimplement deferred inactive to 2/7 vfs: reimplement deferred inactive.
kib accepted this revision.Jan 7 2020, 1:24 PM
kib added inline comments.
sys/kern/vfs_subr.c
2987

Do you need to assert that this is not the last vdrop ?

This revision is now accepted and ready to land.Jan 7 2020, 1:24 PM
mjg added inline comments.Jan 7 2020, 2:16 PM
sys/kern/vfs_subr.c
2987

ok

Closed by commit rS356441: vfs: reimplement deferred inactive to use a dedicated flag (VI_DEFINACT) (authored by mjg). · Explain WhyJan 7 2020, 3:56 PM
This revision was automatically updated to reflect the committed changes.
mjg added a commit: rS356441: vfs: reimplement deferred inactive to use a dedicated flag (VI_DEFINACT).

Revision Contents
Changeset List

PathSize
sys/
compat/
linux/
2 lines
geom/
journal/
2 lines
kern/
2 lines
196 lines
2 lines
sys/
4 lines
1 line

Diff 66363

View Options

sys/compat/linux/linux_stats.c

Loading...
View Options

sys/geom/journal/g_journal.c

Loading...
View Options

sys/kern/vfs_mount.c

Loading...
View Options

sys/kern/vfs_subr.c

Loading...
View Options

sys/kern/vfs_syscalls.c

Loading...
View Options

sys/sys/mount.h

Loading...
View Options

sys/sys/vnode.h

Loading...