mount_smbfs: Issue a warning when .nsmbrc section name contains lowercase characters
ClosedPublic
Actions

for(sectletter = sectname; *sectletter; sectletter++) {
   if(isupper(*sectletter)  || *sectletter == ':')
      continue;
   if(!strcmp(sectname, "default"))
      dprintf(STDERR_FILENO, "warning: Section name [%s] may contain problematic chars, like lower-case letters\n", sectname);
   break;
}

This makes the scan more readable, short cut if the result is known, and keep the search and the response together.

bapt requested changes to this revision.Jan 3 2020, 11:29 AM

bapt added a subscriber: bapt.

bapt added inline comments.

contrib/smbfs/lib/smb/rcfile.c
166–171 ↗	(On Diff #64102)	I like the proposal better, but I think that special chars should be allowed, then testing isupper and !islower should do the trick instead of only testing ':'

This revision now requires changes to proceed.Jan 3 2020, 11:29 AM

donner added inline comments.Jan 3 2020, 11:33 AM

contrib/smbfs/lib/smb/rcfile.c

166–171 ↗

(On Diff #64102)

This would simplify the code to:

for(sectletter = sectname; *sectletter; sectletter++) {
  if(islower(*sectletter)) {
     if(!strcmp(sectname, "default"))
        dprintf(STDERR_FILENO, "warning: Section name [%s] contains lower-case letters\n", sectname);
     break;
  }
}

donner requested changes to this revision.Jan 3 2020, 11:36 AM

Address comments.

Harbormaster completed remote builds in B28456: Diff 66292.Jan 3 2020, 11:56 AM

donner accepted this revision.Jan 3 2020, 12:08 PM

donner added inline comments.

contrib/smbfs/lib/smb/rcfile.c
161–162 ↗	(On Diff #66292)	If the section was found, the check is skipped. That's okay, because the check should be done only if the a new section is encountered the first time.