Page MenuHomeFreeBSD

ncurses: correct check for gcc >= 5.0
ClosedPublic

Authored by kevans on Dec 29 2019, 1:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 4:45 PM
Unknown Object (File)
Feb 18 2025, 12:18 PM
Unknown Object (File)
Feb 13 2025, 7:18 AM
Unknown Object (File)
Feb 9 2025, 3:24 AM
Unknown Object (File)
Feb 8 2025, 11:53 PM
Unknown Object (File)
Feb 1 2025, 10:46 AM
Unknown Object (File)
Jan 27 2025, 2:02 AM
Unknown Object (File)
Nov 29 2024, 9:13 PM
Subscribers

Details

Summary

The hack in question is intended to workaround seemingly bogus #line markers in cpp output. As far as I can tell, llvm cpp doesn't do this by default, so there's no reason to add -P.

In our /bin/sh, the main incantation should be placed in a sub-shell in order to properly pipe the output to fgrep.

The main motivation for this change is admittedly to stop emitting the noise about clang not being gcc in make -s buildworld

Test Plan

`

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 28360

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 14 2020, 4:16 AM
This revision was automatically updated to reflect the committed changes.