Page MenuHomeFreeBSD

Merge commit d3aeac8e2 from llvm git (by Justin Hibbits)
ClosedPublic

Authored by dim on Dec 23 2019, 7:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 15, 10:01 AM
Unknown Object (File)
Thu, Aug 14, 3:10 AM
Unknown Object (File)
Tue, Aug 5, 7:36 AM
Unknown Object (File)
Tue, Aug 5, 6:17 AM
Unknown Object (File)
Fri, Aug 1, 11:33 PM
Unknown Object (File)
Thu, Jul 31, 10:13 AM
Unknown Object (File)
Tue, Jul 29, 11:30 AM
Unknown Object (File)
Tue, Jul 29, 11:15 AM
Subscribers

Details

Summary
[PowerPC] Only use PLT annotations if using PIC relocation model

Summary:

The default static (non-PIC, non-PIE) model for 32-bit powerpc does
not use @PLT annotations and relocations in GCC.  LLVM shouldn't use
@PLT annotations either, because it breaks secure-PLT linking with
(some versions of?) GNU LD.

Update the available-externally.ll test to reflect that default mode
should be the same as the static relocation, by using the same check
prefix.

Reviewed by:    sfertile
Differential Revision: https://reviews.llvm.org/D70570

This diff needed some fuzz to apply, double-checking it via this review.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

contrib/llvm-project/llvm/lib/Target/PowerPC/PPCISelLowering.cpp
4960 ↗(On Diff #65931)

The original diff I had created, before rebasing on the giant refactor used TM.getRelocationModel(). I think this should still work, though.

This revision is now accepted and ready to land.Dec 23 2019, 10:30 PM