libdevdctl: g++9 avoid Wdeprecated-copy
ClosedPublic
Actions

Authored by rlibby on Dec 20 2019, 6:30 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 13, 6:15 PM

	Unknown Object (File)
	Apr 25 2026, 8:57 AM

	Unknown Object (File)
	Apr 18 2026, 7:47 AM

	Unknown Object (File)
	Apr 17 2026, 9:59 PM

	Unknown Object (File)
	Apr 17 2026, 1:54 PM

	Unknown Object (File)
	Apr 15 2026, 11:29 PM

	Unknown Object (File)
	Apr 14 2026, 9:32 AM

	Unknown Object (File)
	Apr 14 2026, 3:42 AM

View All Files

Subscribers

imp

Details

Reviewers

asomers
dim

Commits

rS360302: MFC r355974 (by rlibby):
rS355974: libdevdctl: g++9 avoid Wdeprecated-copy

Summary

g++9 now warns about having defined an assignment operator but using the
default copy constructor, or vice versa. Avoid the issue in libdevdctl
by just using the default assignment operator too.

Test Plan

make CROSS_TOOLCHAIN=amd64-gcc9 buildworld

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28251
Build 26370: arc lint + arc unit

Event Timeline

rlibby created this revision.Dec 20 2019, 6:30 AM

Harbormaster completed remote builds in B28251: Diff 65843.Dec 20 2019, 6:30 AM

LGTM.

This revision is now accepted and ready to land.Dec 20 2019, 6:58 AM

asomers accepted this revision.Dec 20 2019, 3:46 PM

Closed by commit rS355974: libdevdctl: g++9 avoid Wdeprecated-copy (authored by rlibby). · Explain WhyDec 21 2019, 2:44 AM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rS355974: libdevdctl: g++9 avoid Wdeprecated-copy.

Herald added a subscriber: imp. · View Herald TranscriptDec 21 2019, 2:44 AM

dim added a commit: rS360302: MFC r355974 (by rlibby):.Apr 25 2020, 1:03 PM

Revision Contents
Changeset List

Path

Size

lib/

libdevdctl/

guid.h

10 lines

Diff 65843

View Options

libdevdctl: g++9 avoid Wdeprecated-copyClosedPublicActions