Page MenuHomeFreeBSD
Differential D22808

Expand handling of the PCI Vendor ecap
ClosedPublic
Actions

Authored by scottl on Dec 13 2019, 10:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 7, 11:17 AM
Unknown Object (File)
Tue, Apr 29, 8:48 PM
Unknown Object (File)
Wed, Apr 16, 5:40 AM
Unknown Object (File)
Mar 11 2025, 7:03 AM
Unknown Object (File)
Feb 8 2025, 4:17 PM
Unknown Object (File)
Feb 7 2025, 4:14 AM
Unknown Object (File)
Feb 1 2025, 7:43 AM
Unknown Object (File)
Jan 12 2025, 6:36 PM
View All 53 Files
Subscribers
None

Details

Reviewers
jhb
imp
Group Reviewers
manpages
Commits
rS355741: Add accessors for the Vendor Specific Extended Capability (VSEC)
Summary

Add accessors for the Vendor Specific Extended Capability (VSEC)
Parse out the VSEC. If the user invokes a second -c command line option,
do a hex dump of the vendor data.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28143
Build 26279: arc lint + arc unit

Event Timeline

scottl created this revision.Dec 13 2019, 10:59 PM
Herald added a reviewer: manpages. · View Herald TranscriptDec 13 2019, 10:59 PM
Harbormaster completed remote builds in B28143: Diff 65635.Dec 13 2019, 10:59 PM
imp added inline comments.Dec 13 2019, 11:39 PM
usr.sbin/pciconf/cap.c
908

don't you need a printf("\n"); at the end?

scottl added inline comments.Dec 13 2019, 11:41 PM
usr.sbin/pciconf/cap.c
908

The ((i + 4) >= len) clause handles that.

imp accepted this revision.Dec 13 2019, 11:42 PM

I knew I was missing something :).
This looks OK to my eye now

This revision is now accepted and ready to land.Dec 13 2019, 11:42 PM
Closed by commit rS355741: Add accessors for the Vendor Specific Extended Capability (VSEC) (authored by scottl). · Explain WhyDec 13 2019, 11:47 PM
This revision was automatically updated to reflect the committed changes.
scottl added a commit: rS355741: Add accessors for the Vendor Specific Extended Capability (VSEC).

Revision Contents
Changeset List

PathSize
sys/
dev/
pci/
7 lines
usr.sbin/
pciconf/
36 lines
2 lines
3 lines
4 lines

Diff 65635

View Options

sys/dev/pci/pcireg.h

Loading...
View Options

usr.sbin/pciconf/cap.c

Loading...
View Options

usr.sbin/pciconf/pciconf.h

Loading...
View Options

usr.sbin/pciconf/pciconf.8

Loading...
View Options

usr.sbin/pciconf/pciconf.c

Loading...